Closed Bug 1424602 Opened 2 years ago Closed 2 years ago

SM: Restore the Preferences bindings/styles after their removal in bug 1379338

Categories

(SeaMonkey :: Preferences, enhancement)

enhancement
Not set

Tracking

(seamonkey2.56 fixed)

RESOLVED FIXED
seamonkey2.56
Tracking Status
seamonkey2.56 --- fixed

People

(Reporter: Paenglab, Assigned: stefanh)

References

Details

Attachments

(3 files)

Bug 1379338 removes bindings and styles for the windowed preferences. Because we still use them, we need to move them to c-c.

The TB bug 1424601 has an already working patch.
I'm going to be away for a couple of days, but I'll look at this when I get back.
Assignee: nobody → stefanh
This is part 1 and restores the removed bindings. Applies on top of the patches in bug 1418094 and Richards patch in bug 1424601.
Attachment #8938900 - Flags: review?(iann_bugzilla)
Status: NEW → ASSIGNED
This is part 2, it adds Mac and linux versions of the windows preferences.css file.
Attachment #8938901 - Flags: review?(iann_bugzilla)
This is part 3 which adds back the removed style rules. I haven't done any deep investigation, but there could be rules that we don't use (like radio[pane]), likewise some bindings.
Attachment #8938902 - Flags: review?(iann_bugzilla)
Comment on attachment 8938900 [details] [diff] [review]
Part 1: Restore bindings.

>+++ b/suite/common/communicator.css

> prefwindow[xpfe="false"] {
>-  -moz-binding: url("chrome://global/content/bindings/preferences.xml#prefwindow");
>+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#prefwindow");
> }
> 
> prefpane[xpfe="false"] {
>-  -moz-binding: url("chrome://global/content/bindings/preferences.xml#prefpane");
>+  -moz-binding: url("chrome://communicator/content/bindings/preferences.xml#prefpane");
> }
> 
> findbar[xpfe="false"] {
>   -moz-binding: url("chrome://global/content/bindings/findbar.xml#findbar");
> }
> 
> prefwindow[xpfe="false"] > .paneDeckContainer,
> prefpane[xpfe="false"] > .content-box {

Do we make use of the [xpfe="false"] any more for prefwindow, prefpane, findbar, etc? Maybe for another bug...

r=me
Attachment #8938900 - Flags: review?(iann_bugzilla) → review+
Attachment #8938901 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8938902 [details] [diff] [review]
Part 3: Add missing style rules to Linux/Mac/Windows preferences.css files.

r=me
Attachment #8938902 - Flags: review?(iann_bugzilla) → review+
Target Milestone: --- → Seamonkey2.56
Pushed by stefanh@inbox.com:
https://hg.mozilla.org/comm-central/rev/5087b6ba1eeb
Restore suite Preferences bindings/styles after their removal in bug 1379338: Part 1 (restore bindings). r=IanN.
https://hg.mozilla.org/comm-central/rev/6f7be81e3c4e
Restore suite Preferences bindings/styles after their removal in bug 1379338: Part 2 (add Linux/Mac preferences.css files). r=IanN.
https://hg.mozilla.org/comm-central/rev/8afc685a7b48
Restore suite Preferences bindings/styles after their removal in bug 1379338: Part 3 (add missing style rules to Linux/Mac/Windows preferences.css files). r=IanN.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Depends on: 1432590
Depends on: 1433814
You need to log in before you can comment on or make changes to this bug.