Closed Bug 1424670 Opened 2 years ago Closed 2 years ago

Bug 1423958 followup - stub installer check for Lenovo DLL support non-en_US Windows builds

Categories

(Firefox :: Installer, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: mhowell, Assigned: mhowell)

References

Details

Attachments

(1 file)

As pointed out in bug 1423958 comment 8, Program Files paths should never be hard-coded; the appropriate variable should always be used. That patch needs to be amended with this change.
Attachment #8936196 - Flags: review?(agashlin) → review?(cpeterson)
Comment on attachment 8936196 [details]
Bug 1424670 - Don't hard code a Program Files path.

https://reviewboard.mozilla.org/r/206968/#review213066

LGTM AFAICT from reading NSIS example using $PROGRAMFILES32.
Attachment #8936196 - Flags: review?(cpeterson) → review+
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d857c4a04d2d
Don't hard code a Program Files path. r=cpeterson
Comment on attachment 8936196 [details]
Bug 1424670 - Don't hard code a Program Files path.

Approval Request Comment
This is a small followup to fix a bug that prevents bug 1423958 from working properly on most affected systems. It should be uplifted along with that patch. See bug 1423958 comment 9 for the relevant uplift request.
Attachment #8936196 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/d857c4a04d2d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
We would like to uplift this fix to Beta 58 as a follow-up for bug 1423958.
Summary: Bug 1423958 followup - support non-en_US Windows builds → Bug 1423958 followup - stub installer check for Lenovo DLL support non-en_US Windows builds
Comment on attachment 8936196 [details]
Bug 1424670 - Don't hard code a Program Files path.

Added fix for an already uplifted patch to block 64-bit installs on particular Lenovo machines. Let's uplift this fix for 58.0b12.
Attachment #8936196 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.