1424677 - Don't use wstring for nsIEditorSpellCheck

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

No reason to use wstring.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=113608683218bdadc2da2a901639c102e115a3d0

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1424677 - Don't use wstring for nsIEditorSpellCheck.

nsIEditorSpellCheck still uses wstring.  We should replace it with AString
to avoid additional memory allocation.

Review commit: https://reviewboard.mozilla.org/r/207282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207282/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8936549 [details]
Bug 1424677 - Don't use wstring for nsIEditorSpellCheck.

https://reviewboard.mozilla.org/r/207282/#review213098

Really nice! I guess that this patch reduces redundant allocation.

::: editor/composer/nsEditorSpellCheck.cpp:477
(Diff revision 1)
> -nsEditorSpellCheck::CheckCurrentWord(const char16_t *aSuggestedWord,
> +nsEditorSpellCheck::CheckCurrentWord(const nsAString& aSuggestedWord,
>                                       bool *aIsMisspelled)

When you touch an argument whose coding style is odd, I'd like you to clean up other arguments too. However, it's not your fault, so, keeping current style for the bool* argument is okay.

::: editor/composer/nsEditorSpellCheck.cpp:488
(Diff revision 1)
> -nsEditorSpellCheck::CheckCurrentWordNoSuggest(const char16_t *aSuggestedWord,
> +nsEditorSpellCheck::CheckCurrentWordNoSuggest(const nsAString& aSuggestedWord,
>                                                bool *aIsMisspelled)

ditto.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f95d6e7520
Don't use wstring for nsIEditorSpellCheck. r=masayuki

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c6f95d6e7520