Closed
Bug 1424808
Opened 6 years ago
Closed 6 years ago
Get rid of isFileStream in nsHttpChannel.cpp
Categories
(Core :: Networking, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
3.86 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
In nsHttpChannel we have a isFileStream static function. This checks if a stream is a file stream in order to avoid doing I/O on the main-thread. But what we really want to do is to check if the stream is blocking. This bug is about removing isFileStream and replace it with a better check.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8936324 -
Flags: review?(valentin.gosu)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8936324 [details] [diff] [review] blocking.patch Review of attachment 8936324 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8936324 -
Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b011726c6a13 Get rid of isFileStream in nsHttpChannel.cpp, r=valentin
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b011726c6a13
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•