Closed Bug 1424835 Opened 2 years ago Closed 2 years ago
The buttons “Disable” and “Remove” from Yandex move down in the options
[Affected versions]: - Firefox 59.0a1 (20171211220110) - Firefox 58.0b11 (20171211020921) - Firefox 57.0.2 (20171206182557) [Affected platforms]: - Win 7 64-bit - Ubuntu 16.04 32-bit [Steps to reproduce]: 1.Install https://addons.mozilla.org/en-US/firefox/addon/yandexbar/?src=cb-dl-users 2.Go to the about:addons web page. 3.Click on the “Options” button. 4.Scroll down until you see the “Disable” and “Remove” buttons. 5.Observe the buttons. [Expected results]: - The buttons are not moving down in the options_ui. [Actual results]: - The buttons move down in the options_ui. Affected extensions: Yandex Elements: Mail v.8.23.2, Yandex Elements: Traffic v.8.23.0, Yandex Elements: Weather v.8.23.0 Please see the attached video.
I can reproduce this on Windows.
Assignee: nobody → tomica
I think this comes down to feedback between these two lines: https://searchfox.org/mozilla-central/rev/9d920555ec81f1c9d4b7fa3b08e23eb88efb60e1/toolkit/components/extensions/ext-browser-content.js#256 https://searchfox.org/mozilla-central/rev/9d920555ec81f1c9d4b7fa3b08e23eb88efb60e1/toolkit/mozapps/extensions/content/extensions.js#3301 If the body padding is a fractional pixel, then we round up, which then makes the body of the options browser a pixel larger. Then we do that again. And again. And again... I suspect bug 1424615 might be related too. Kris, I think you originally wrote this code, any thoughts?
Comment on attachment 8937095 [details] Bug 1424835: Prevent inline options browsers from continuing to grow after certain rounding errors. https://reviewboard.mozilla.org/r/207804/#review213692 oy
Attachment #8937095 - Flags: review?(aswan) → review+
Assignee: tomica → kmaglione+bmo
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2b87439996443fa69171fda33938c632bb1630a Bug 1424835: Prevent inline options browsers from continuing to grow after certain rounding errors. r=aswan
This issue is verified as fixed on Firefox 59.0a1 (20171217220404) under Win 7 64-bit and Ubuntu 16.04 32-bit. Please see the attached video.
You need to log in before you can comment on or make changes to this bug.