Closed Bug 1424867 Opened 2 years ago Closed 2 years ago

Fix some "type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]" warnings

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(3 files)

/root/firefox-gcc-last/toolkit/components/url-classifier/LookupCache.cpp: In function 'void mozilla::safebrowsing::CStringToHexStrin
g(const nsACString&, nsACString&)':
 /root/firefox-gcc-last/toolkit/components/url-classifier/LookupCache.cpp:62:50: error: type qualifiers ignored on cast result type [
-Werror=ignored-qualifiers]
      const char c = static_cast<const char>(aIn[i]);

                                                   ^
and others
Assignee: nobody → sledru
Comment on attachment 8936382 [details]
Bug 1424867 - Fix an ignored-qualifiers warning in nsFind.cpp

https://reviewboard.mozilla.org/r/207112/#review212946

rs+
Attachment #8936382 - Flags: review?(bugs) → review+
Comment on attachment 8936383 [details]
Bug 1424867 - Fix an ignored-qualifiers warning in BindingUtils

https://reviewboard.mozilla.org/r/207114/#review212950

rs+
Attachment #8936383 - Flags: review?(bugs) → review+
Comment on attachment 8936381 [details]
Bug 1424867 - Fix some ignored-qualifiers warnings in url-classifier & reputationservice

https://reviewboard.mozilla.org/r/207110/#review213068
Attachment #8936381 - Flags: review?(francois) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf2e50c35634
Fix some ignored-qualifiers warnings in url-classifier & reputationservice r=francois
https://hg.mozilla.org/integration/autoland/rev/cc84eaae17da
Fix an ignored-qualifiers warning in nsFind.cpp r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d31313a92eb
Fix an ignored-qualifiers warning in BindingUtils r=smaug
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.