Closed Bug 1424922 Opened 2 years ago Closed 2 years ago

Crash in mozilla::ipc::MessageChannel::Close from PDFiumProcessParent::Delete

Categories

(Core :: Printing: Output, defect, critical)

59 Branch
Unspecified
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: calixte, Assigned: u459114)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-bcd6f013-20d1-4022-ba55-a09cf0171211.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::ipc::MessageChannel::Close ipc/glue/MessageChannel.cpp:2711
1 xul.dll mozilla::widget::PDFiumProcessParent::`scalar deleting destructor' 
2 xul.dll mozilla::widget::PDFiumProcessParent::Delete widget/windows/PDFiumProcessParent.cpp:65
3 xul.dll mozilla::widget::PDFiumParent::ActorDestroy widget/windows/PDFiumParent.cpp:39
4 xul.dll mozilla::gfx::PVsyncBridgeParent::OnChannelClose ipc/ipdl/PVsyncBridgeParent.cpp:158
5 xul.dll mozilla::ipc::MessageChannel::NotifyChannelClosed ipc/glue/MessageChannel.cpp:2746
6 xul.dll mozilla::ipc::MessageChannel::Close ipc/glue/MessageChannel.cpp:2723
7 xul.dll mozilla::widget::PDFiumProcessParent::Delete widget/windows/PDFiumProcessParent.cpp:58
8 xul.dll mozilla::gfx::PrintTargetEMF::~PrintTargetEMF gfx/thebes/PrintTargetEMF.cpp:33
9 xul.dll mozilla::gfx::PrintTargetEMF::`scalar deleting destructor' 

=============================================================

There are 5 crashes in nightly 59 starting with buildid 20171211105838 containing PDFiumProcessParent in proto signature (see [1]). In analyzing the backtrace, the regression may have been introduced by patch [2] to fix bug 1399787.

[1] http://bit.ly/2BWtQN7
[2] https://hg.mozilla.org/mozilla-central/rev/9211d19c1075
Flags: needinfo?(cku)
Assignee: nobody → cku
Flags: needinfo?(cku)
Attachment #8936537 - Flags: review?(jwatt)
Attachment #8936537 - Flags: review?(dvander)
Comment on attachment 8936537 [details]
Bug 1424922 - Prevent calling PDFiumParent::Close twice.

https://reviewboard.mozilla.org/r/207222/#review213252
Attachment #8936537 - Flags: review?(dvander) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8320a9f9de3e
Prevent calling PDFiumParent::Close twice. r=dvander
Comment on attachment 8936537 [details]
Bug 1424922 - Prevent calling PDFiumParent::Close twice.

https://reviewboard.mozilla.org/r/207222/#review213622
Attachment #8936537 - Flags: review?(jwatt) → review+
https://hg.mozilla.org/mozilla-central/rev/8320a9f9de3e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.