Reword the label for the "Open new windows in a new tab instead" item in the preferences/settings/options

VERIFIED FIXED in Firefox 59

Status

()

defect
P5
trivial
VERIFIED FIXED
2 years ago
Last year

People

(Reporter: rexax007, Assigned: Gijs)

Tracking

57 Branch
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 verified)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171206182557

Steps to reproduce:

1. Go to "about:preferences#general"
2. Scroll to Tabs
3. Invert selection of "Open new windows in a new tab instead"


Actual results:

When "Open new windows in a new tab instead" is checked link opens in a new tab


Expected results:

When "Open new windows in a new tab instead" is checked link should open in a new window
Reporter

Updated

2 years ago
Component: Untriaged → General
OS: Unspecified → All
Hardware: Unspecified → All

Comment 1

2 years ago
(Open new windows) (in a new tab) (instead).

This is really not very fluent.
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Component: General → Preferences
Ever confirmed: true
Assignee

Comment 2

2 years ago
Michelle, we have a preference for what happens when links specify they need to open in a new <thing> (ie not the same tab as the link is in). The pref governs whether we open the target of the link in a new tab or a new window. Originally, such things always opened windows. As a result the checkbox is currently phrased "Open new windows in new tabs instead". Can you think of a better phrasing?
Flags: needinfo?(mheubusch)
Assignee

Updated

2 years ago
Summary: "Open new windows in a new tab instead" check box inverted → Reword the label for the "Open new windows in a new tab instead" item in the preferences/settings/options
Assignee

Updated

2 years ago
Priority: -- → P5
Reporter

Comment 3

2 years ago
(In reply to :Gijs from comment #2)
> Michelle, we have a preference for what happens when links specify they need
> to open in a new <thing> (ie not the same tab as the link is in). The pref
> governs whether we open the target of the link in a new tab or a new window.
> Originally, such things always opened windows. As a result the checkbox is
> currently phrased "Open new windows in new tabs instead". Can you think of a
> better phrasing?

Open Links for new task in a new Windows
Reporter

Comment 4

2 years ago
This option can be removed making opening in tab default and "new tab link" opens in open window when clicked while holding down Shift.

Comment 5

2 years ago
Hi Meridel - assigning this to you for copywriting.  The message we need to convey is "When this box is checked, any links that are designated to open in a new window will open in a new tab in the same window instead"
Flags: needinfo?(mheubusch) → needinfo?(mwalkington)

Comment 6

2 years ago
Please reword label as: Open links as tabs instead of new windows

Michelle approved the change.
Flags: needinfo?(mwalkington) → needinfo?(gijskruitbosch+bugs)
Assignee

Updated

2 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Comment hidden (mozreview-request)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8939854 [details]
Bug 1424970 - adjust label for preferring tabs over windows for _blank links,

https://reviewboard.mozilla.org/r/210164/#review215898
Attachment #8939854 - Flags: review?(jaws) → review+

Comment 9

2 years ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a584dc4c2266
adjust label for preferring tabs over windows for _blank links, r=jaws

Comment 10

2 years ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/e3512368ff7a
adjust label for preferring tabs over windows for _blank links, r=jaws

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e3512368ff7a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59

Comment 13

2 years ago
I would expect the new string to use "in" (tabs) rather than "as" for several reasons. Thoughts? Compare:

Open links in tabs instead of new windows
Open links as tabs instead of new windows
I have reproduced this bug with Nightly 59.0a1 (2017-12-12) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly as per comment 6.

Build ID 	20180106100308
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
QA Whiteboard: [bugday-20180103]
I have reproduced this bug with Nightly 59.0a1 (2017-12-12) on Windows 10, 64 bit!

The bug's fix is verified with latest Nightly!

Build ID 	20180106100308
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180103]
As per Comment 14 and Comment 15, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
Assignee

Comment 17

Last year
(In reply to Ton from comment #13)
> I would expect the new string to use "in" (tabs) rather than "as" for
> several reasons. Thoughts? Compare:
> 
> Open links in tabs instead of new windows
> Open links as tabs instead of new windows

I don't think it makes a substantial difference in English. You said you have several reasons - if you feel strongly, please file a follow-up bug with those reasons?

Comment 18

Last year
Per Comment 17, I agree that "Open links in tabs instead of new windows" would be more accurate. 

Apologies for the late edit, and thank you,  Gijs, for the suggestion. 

Can we make this change?
Assignee

Updated

Last year
Blocks: 1429456
You need to log in before you can comment on or make changes to this bug.