1424970 - Reword the label for the "Open new windows in a new tab instead" item in the preferences/settings/options

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[QWERTY]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171206182557

Steps to reproduce:

1. Go to "about:preferences#general"
2. Scroll to Tabs
3. Invert selection of "Open new windows in a new tab instead"


Actual results:

When "Open new windows in a new tab instead" is checked link opens in a new tab


Expected results:

When "Open new windows in a new tab instead" is checked link should open in a new window

Comment 1

[YF (Yang)]

(Open new windows) (in a new tab) (instead).

This is really not very fluent.

Comment 2

[:Gijs (he/him)]

Michelle, we have a preference for what happens when links specify they need to open in a new <thing> (ie not the same tab as the link is in). The pref governs whether we open the target of the link in a new tab or a new window. Originally, such things always opened windows. As a result the checkbox is currently phrased "Open new windows in new tabs instead". Can you think of a better phrasing?

Comment 3

[QWERTY]

(In reply to :Gijs from comment #2)
> Michelle, we have a preference for what happens when links specify they need
> to open in a new <thing> (ie not the same tab as the link is in). The pref
> governs whether we open the target of the link in a new tab or a new window.
> Originally, such things always opened windows. As a result the checkbox is
> currently phrased "Open new windows in new tabs instead". Can you think of a
> better phrasing?

Open Links for new task in a new Windows

Comment 4

[QWERTY]

This option can be removed making opening in tab default and "new tab link" opens in open window when clicked while holding down Shift.

Comment 5

[mheubusch]

Hi Meridel - assigning this to you for copywriting.  The message we need to convey is "When this box is checked, any links that are designated to open in a new window will open in a new tab in the same window instead"

Comment 6

[Meridel [:meridel]]

Please reword label as: Open links as tabs instead of new windows

Michelle approved the change.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1424970 - adjust label for preferring tabs over windows for _blank links,

Review commit: https://reviewboard.mozilla.org/r/210164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210164/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8939854 [details]
Bug 1424970 - adjust label for preferring tabs over windows for _blank links,

https://reviewboard.mozilla.org/r/210164/#review215898

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a584dc4c2266
adjust label for preferring tabs over windows for _blank links, r=jaws

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/e3512368ff7a
adjust label for preferring tabs over windows for _blank links, r=jaws

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e3512368ff7a

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/a584dc4c2266

Comment 13

[Ton [:Tonnes]]

I would expect the new string to use "in" (tabs) rather than "as" for several reasons. Thoughts? Compare:

Open links in tabs instead of new windows
Open links as tabs instead of new windows

Comment 14

[Md. Majedul islam]

I have reproduced this bug with Nightly 59.0a1 (2017-12-12) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly as per comment 6.

Build ID 	20180106100308
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 15

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 59.0a1 (2017-12-12) on Windows 10, 64 bit!

The bug's fix is verified with latest Nightly!

Build ID 	20180106100308
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

[bugday-20180103]

Comment 16

[Md. Majedul islam]

As per Comment 14 and Comment 15, I am marking this bug as verified fixed.

Comment 17

[:Gijs (he/him)]

(In reply to Ton from comment #13)
> I would expect the new string to use "in" (tabs) rather than "as" for
> several reasons. Thoughts? Compare:
> 
> Open links in tabs instead of new windows
> Open links as tabs instead of new windows

I don't think it makes a substantial difference in English. You said you have several reasons - if you feel strongly, please file a follow-up bug with those reasons?

Comment 18

[Meridel [:meridel]]

Per Comment 17, I agree that "Open links in tabs instead of new windows" would be more accurate. 

Apologies for the late edit, and thank you,  Gijs, for the suggestion. 

Can we make this change?