1425071 - [templates] Nothing emitted for some symbols inside GC tracer templates

Status: RESOLVED WORKSFORME

(Webtools :: Searchfox, enhancement)

Description

[Paul Bone [:pbone]]

For example:

https://searchfox.org/mozilla-central/source/js/src/gc/Tracer.cpp#48

Some things here are not clickable, like dispatchToOnEdge, I think that searchfox is confused by the comment on line 40, maybe it can't find the end of the comment?  I'm not sure.

When I search for an item like this these uses are shown as textual occurances.

Thanks.

Comment 1

[Andrew McCreight [:mccr8]]

I don't think this is related to the comment. A C++ thing doesn't get linkified if the analysis doesn't emit anything for it, which can happen for various reasons. There's a bunch of templated things involved here, and handling that is tricky, so likely something isn't being handled correctly.

Specifically, inside the definition of the template DoCallback, CheckTracedThing and dispatchToOnEdge aren't linked to anything.

js::CheckTracedThing and CheckTracedFunctor in this file also have this problem.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Permalink for dispatchToOnEdge: https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/js/src/gc/Tracer.cpp#45

Comment 4

[Tooru Fujisawa [:arai]]

Not reproducible with the latest files, except that some functions no longer exist.
The improvements on the template and also to the macro expansion should've helped some cases.