Closed Bug 1425077 Opened 4 years ago Closed 4 years ago
Script can have an error to rethrow but no module object
ModuleScript::SetErrorToRethrow() should call HoldJSObjects but it doesn't.
I realised that the code is fine as it is, because for SetErrorToRethrow() to be called we must have either called SetModuleRecord() or SetParseError() first. This patch adds an assertion and a comment.
Attachment #8936911 - Flags: review?(amarchesini)
Attachment #8936911 - Flags: review?(amarchesini) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/83a66733b7e5 Make ModuleScript::SetErrorToRethrow call HoldJSObjects in case there is no module record r=baku
You need to log in before you can comment on or make changes to this bug.