Closed Bug 1425095 Opened 2 years ago Closed 2 years ago

[in-tree relpro] Add balrog publishing task

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed

People

(Reporter: jlorenzo, Assigned: jlorenzo)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch 1425095.patch (obsolete) — Splinter Review
Attachment #8936657 - Flags: review?(bhearsum)
Attached patch 1425095-part2.patch (obsolete) — Splinter Review
Follow up fix to get all the parameters needed by the balrog client.
Attachment #8936890 - Flags: review?(bhearsum)
Attachment #8936657 - Flags: review?(bhearsum) → review+
Comment on attachment 8936890 [details] [diff] [review]
1425095-part2.patch

Review of attachment 8936890 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/taskgraph/transforms/job/buildbot.py
@@ +32,5 @@
>  })
>  
>  
> +def _get_balrog_api_root(branch):
> +    return 'https://aus4-admin.mozilla.org/api' if branch in ('mozilla-beta', 'mozilla-release') \

This need to include ESR branches as well. Ideally, matching any ESR branch. Will this be used for nightly builds as well? If so, mozilla-central should be in here.
Attachment #8936890 - Flags: review?(bhearsum) → feedback+
Attachment #8936657 - Attachment is obsolete: true
Attachment #8936890 - Attachment is obsolete: true
Attachment #8937115 - Flags: review?(bhearsum)
Comment on attachment 8937115 [details] [diff] [review]
1425095-rev2.patch

I'll get this landed on inbound.
Attachment #8937115 - Flags: review?(bhearsum) → review+
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb24cbab90a7
add in-tree balrog publishing tasks. r=bhearsum
https://hg.mozilla.org/mozilla-central/rev/cb24cbab90a7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
I think we need a balrog publishing task for beta channel on RCs (but not most point releases). We had to do similar for update verify, here's some potentially helpful links:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/target_tasks.py#335
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/release-secondary-final-verify/kind.yml
https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/release-update-verify/kind.yml#227
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I think we can close this, no?
Flags: needinfo?(bhearsum)
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Flags: needinfo?(bhearsum)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.