Closed Bug 1425139 Opened 3 years ago Closed 3 years ago

Lightning's "Today pane" button is dark text with a dark LW theme

Categories

(Thunderbird :: Theme, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 59.0

People

(Reporter: aceman, Assigned: Paenglab)

Details

Attachments

(1 file)

Lightning's "Today pane" button in the status bar of Thunderbird has dark text when it is pressed or hovered, if you have a LW theme with dark background (image). It is barely visible. When it is not pressed, it has a light text color as other text in the status bar (e.g. status messages when connecting to server).
No CC needed when I'm the assignee. ;)
This fixes the issue. I also better align the text in the status bar with the today pane button.

The #status-bar:-moz-lwtheme is not needed as the :root:-moz-lwtheme does its work here. Instead I'm using the place for the toolbarbutton.

Windows was affected too but Mac not.
Attachment #8936928 - Flags: review?(acelists)
Comment on attachment 8936928 [details] [diff] [review]
Statusbar-color.patch

Review of attachment 8936928 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this makes the text color match the other widgets.
There was also an arrow right of the label (in TB52). Is that vanished now? If it is gone, we need some other indication whether the pane is open or not. There is now no changed color and no arrow direction. Maybe some 'pressed down'/embossed border could be added?
Attachment #8936928 - Flags: feedback+
I noticed this too. It's because the icon was removed in m-c.

I file a calendar bug for this to bring this arrow back.
Comment on attachment 8936928 [details] [diff] [review]
Statusbar-color.patch

Review of attachment 8936928 [details] [diff] [review]:
-----------------------------------------------------------------

OK, thanks, but then also make the arrow inherit the text color, not always black.
Attachment #8936928 - Flags: review?(acelists) → review+
(In reply to :aceman from comment #5)
> OK, thanks, but then also make the arrow inherit the text color, not always
> black.

That is the plan.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/32ac7a019454
Priorize the LW-theme color on toolbarbuttons in statusbar. r=aceman
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
You need to log in before you can comment on or make changes to this bug.