Closed Bug 1425173 Opened 2 years ago Closed 2 years ago

"Unknown label for categorical histogram" is logged when open about:preferences#search

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: magicp.jp, Assigned: Fischer)

Details

Attachments

(2 files)

Steps to reproduce:
1. Launch Nightly
2. Open about:preferences#search

Actual Results:
"Unknown label for categorical histogram" is logged in the browser console.

Expected Results:
No errors.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85928fde7206dbd063b4ef7c656eb7e5e835a770&tochange=5654a60499973490633adb7eb715467a99894622
Fischer, this looks very close to what the problem you were seeing in bug 1427973. Can you take a look at this?
Flags: needinfo?(fliu)
Priority: -- → P1
Comment on attachment 8942051 [details]
Bug 1425173 - Fix the missing "search" category and extend the expire time for FX_PREFERENCES_CATEGORY_OPENED_V2

https://reviewboard.mozilla.org/r/212262/#review218038

::: toolkit/components/telemetry/Histograms.json:6562
(Diff revision 1)
>      "record_in_processes": ["main", "content"],
> -    "bug_numbers": [1335907],
> +    "bug_numbers": [1335907, 1425173],
>      "alert_emails": ["jaws@mozilla.com"],
>      "expires_in_version": "59",
>      "kind": "categorical",
> -    "labels": ["unknown", "searchresults", "general", "applications", "privacy", "sync", "advanced"],
> +    "labels": ["unknown", "searchresults", "general", "applications", "privacy", "sync", "advanced", "search"],

Thinking a better way might be instead of relying on the hard-coded categories in the internal `telemetryBucketForCategory` to check the validity, to get the valid catrgory labels from the histogram is more reliable. However, not found related ways in nsITelemetry.idl and TelemetryEnvironment.jsm...
Assignee: nobody → fliu
Status: NEW → ASSIGNED
Flags: needinfo?(fliu)
Hi Chenxia,

For the "FX_PREFERENCES_CATEGORY_OPENED_V2" telemetry, we
- Extend the expire time from 59 to 66
- Add one missing "search" category for it

Would you help to take a look? Thanks
Attachment #8942054 - Flags: review?(liuche)
Comment on attachment 8942051 [details]
Bug 1425173 - Fix the missing "search" category and extend the expire time for FX_PREFERENCES_CATEGORY_OPENED_V2

https://reviewboard.mozilla.org/r/212262/#review218060

::: commit-message-f7f5b:3
(Diff revision 2)
> +Bug 1425173 - Fix the missing "search" category and extend the expire time for FX_PREFERENCES_CATEGORY_OPENED_V2
> +
> +- Extend the expire time from 59 to 66

Checked with PM Cindy. We still want this telemetry ping till FF66
Comment on attachment 8942051 [details]
Bug 1425173 - Fix the missing "search" category and extend the expire time for FX_PREFERENCES_CATEGORY_OPENED_V2

https://reviewboard.mozilla.org/r/212262/#review218226
Attachment #8942051 - Flags: review?(jaws) → review+
Comment on attachment 8942054 [details] [diff] [review]
1425173_data_review

Thanks for filling out the form, Fischer! FWIW you don't need to fill out the "review" page, just the "request". The review is for the data peers to fill out.

----

data-review+ only

> Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? (see here, here, and here for examples).

Histograms.js

> Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, Firefox data controls

> If the request is for permanent data collection, is there someone who will monitor the data over time?**

expires in 66, jaws will monitor

> Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? **

Type 2

> Is the data collection request for default-on or default-off?

on

> Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

no

> Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

expires in 66
Attachment #8942054 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] - not actively working on Fennec from comment #8)
> Comment on attachment 8942054 [details] [diff] [review]
> 1425173_data_review
> 
> Thanks for filling out the form, Fischer! FWIW you don't need to fill out
> the "review" page, just the "request". The review is for the data peers to fill out.
> 
Thanks got it.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2194f63a80bf
Fix the missing "search" category and extend the expire time for FX_PREFERENCES_CATEGORY_OPENED_V2 r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2194f63a80bf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.