Closed
Bug 1425185
Opened 7 years ago
Closed 3 years ago
Remove dead code from nsDeviceContextSpecGTK::MakePrintTarget
Categories
(Core :: Printing: Setup, enhancement, P3)
Core
Printing: Setup
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
1.24 KB,
patch
|
Details | Diff | Splinter Review |
nsDeviceContextSpecGTK::MakePrintTarget calls nsPrintSettingsGTK::GetOutputFormat then checks whether it returns nsIPrintSettings::kOutputFormatNative. That can't happen since nsPrintSettingsGTK::GetOutputFormat converts kOutputFormatNative to kOutputFormatPS or kOutputFormatPDF.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8936741 -
Flags: review?(bobowencode)
|
|
Assignee | |
Comment 2•7 years ago
|
||
(In reply to Jonathan Watt [:jwatt] (needinfo? me) from comment #0)
> That can't happen since
> nsPrintSettingsGTK::GetOutputFormat converts kOutputFormatNative to
> kOutputFormatPS or kOutputFormatPDF.
That's not true. The last branch is an 'if-else', not 'if';
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8936741 -
Flags: review?(bobowencode)
|
||
Updated•7 years ago
|
Priority: -- → P1
|
|
||
Updated•7 years ago
|
Priority: P1 → P3
|
|
Assignee | |
Comment 3•3 years ago
|
||
I fixed this in bug 1322756.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•