Closed
Bug 1425203
Opened 6 years ago
Closed 6 years ago
Update gdb support code to use new signature of wasm SIGSEGV/SIGBUS handler.
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Actual results: Bug 1419224 made WasmFaultHandler a non template function making asmjs.py error with: Python Exception <class 'gdb.error'> No symbol "WasmFaultHandler<(Signal)0>" in current context.
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #8936767 -
Flags: review?(luke)
|
|
||
Updated•6 years ago
|
status-firefox59:
--- → affected
Priority: -- → P2
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8936767 [details] [diff] [review] bug1425203.patch Review of attachment 8936767 [details] [diff] [review]: ----------------------------------------------------------------- Stealing, trivial. Thanks for the patch! (can be checked in without try build, it's tooling only and not tested)
Attachment #8936767 -
Flags: review?(luke) → review+
|
|
||
Updated•6 years ago
|
Assignee: nobody → dragan.mladjenovic
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69ecf79f0dcb Update gdb support code to use new signature of wasm SIGSEGV/SIGBUS handler. r=bbouvier
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/69ecf79f0dcb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•