Closed Bug 1425209 Opened 2 years ago Closed 2 years ago

[Static Analysis] 'Constant' variable guards dead code in nsXULTemplateQueryProcessorRDF::CompileSimpleQuery

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1425969)

Attachments

(1 file)

The Static Analysis tool Coverity detected that the following code will never be executed:

>>            if (hasContainerTest)
>>                continue;

This is because of this:

>>    bool hasContainerTest = false;

I don't see any place where |hasContainerTest| changes so I think we can eliminate it.
Comment on attachment 8936777 [details]
Bug 1425209 - remove dead code in CompileSimpleQuery.

https://reviewboard.mozilla.org/r/207488/#review213410

Thank you!
Attachment #8936777 - Flags: review?(bzbarsky) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a4cd9c278dd
remove dead code in CompileSimpleQuery. r=bz
https://hg.mozilla.org/mozilla-central/rev/5a4cd9c278dd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.