1425255 - Clamp screenshots to the available screen size

Status: NEW

(Testing :: mozscreenshots, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Some screenshots are including parts of the Windows task bar because we actually draw the window slightly behind the Windows task bar. Using screen.avail* will help us to crop the image to just what is actually available on the screen.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1425255 - Clamp the screenshot cropping to the screen.avail* properties so we don't include parts of the Windows task bar.

Review commit: https://reviewboard.mozilla.org/r/207550/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207550/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I have confirmed that the attached patch fixes the bug through locally running the mozscreenshots tool.

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8936846 [details]
Bug 1425255 - Clamp the screenshot cropping to the screen.avail* properties so we don't include parts of the Windows task bar.

https://reviewboard.mozilla.org/r/207550/#review213528

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8936846 [details]
Bug 1425255 - Clamp the screenshot cropping to the screen.avail* properties so we don't include parts of the Windows task bar.

https://reviewboard.mozilla.org/r/207550/#review213570

This breaks Hidpi support