Open Bug 1425255 Opened 3 years ago Updated 3 years ago

Clamp screenshots to the available screen size

Categories

(Testing :: mozscreenshots, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(Not tracked)

People

(Reporter: jaws, Unassigned)

Details

Attachments

(1 file)

Some screenshots are including parts of the Windows task bar because we actually draw the window slightly behind the Windows task bar. Using screen.avail* will help us to crop the image to just what is actually available on the screen.
Attachment #8936846 - Flags: review?(MattN+bmo) → review?(jhofmann)
I have confirmed that the attached patch fixes the bug through locally running the mozscreenshots tool.
Comment on attachment 8936846 [details]
Bug 1425255 - Clamp the screenshot cropping to the screen.avail* properties so we don't include parts of the Windows task bar.

https://reviewboard.mozilla.org/r/207550/#review213528
Attachment #8936846 - Flags: review?(jhofmann) → review+
Comment on attachment 8936846 [details]
Bug 1425255 - Clamp the screenshot cropping to the screen.avail* properties so we don't include parts of the Windows task bar.

https://reviewboard.mozilla.org/r/207550/#review213570

This breaks Hidpi support
Attachment #8936846 - Flags: review-
Assignee: jaws → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.