Closed Bug 1425262 Opened 2 years ago Closed 2 years ago

Let GeckoSession implement GeckoDisplay

Categories

(GeckoView :: General, enhancement)

All
Android
enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(2 files)

Right now there's some back-and-forth between GeckoSession and GeckoView when establishing a GeckoDisplay, which GeckoView implements. We'd like to make it so GeckoSession returns a GeckoDisplay directly to GeckoView. The new APIs will be GeckoSession.acquireDisplay and GeckoSession.releaseDisplay.
Comment on attachment 8937750 [details]
Bug 1425262 - 1. Implement GeckoDisplay as a class managed by GeckoSession;

https://reviewboard.mozilla.org/r/208460/#review214272
Attachment #8937750 - Flags: review?(rbarker) → review+
Comment on attachment 8937751 [details]
Bug 1425262 - 2. Use new GeckoDisplay from GeckoView;

https://reviewboard.mozilla.org/r/208462/#review214274

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoView.java:96
(Diff revision 1)
>  
> -            if (!mValid || listener == null) {
> +            if (!mValid) {
>                  return;
>              }
>  
>              // Tell new listener there is already a surface.

Update comment to reflect the removal of the listener.
Attachment #8937751 - Flags: review?(rbarker) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eea66dfadee4
1. Implement GeckoDisplay as a class managed by GeckoSession; r=rbarker
https://hg.mozilla.org/integration/autoland/rev/48c826bc6bbe
2. Use new GeckoDisplay from GeckoView; r=rbarker
https://hg.mozilla.org/mozilla-central/rev/eea66dfadee4
https://hg.mozilla.org/mozilla-central/rev/48c826bc6bbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8258f42f38c4
3. Follow-up to fix wrong comment; r=me
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 59 → mozilla59
You need to log in before you can comment on or make changes to this bug.