Closed Bug 1425339 Opened 2 years ago Closed 2 years ago

Allow Places tree's selectItems() function to handle guids as well as ids.

Categories

(Firefox :: Bookmarks & History, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

In working on bug 1423896 we realised that we need to support a GUID passed to selectItems() on the places tree.

Doing this will allow us to switch the left folder pane queries to be based around (virtual) GUIDs which helps with the switch to virtual queries that we need to do.

This also helps with the general move away from ids to GUIDs.
Comment on attachment 8936938 [details]
Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids.

https://reviewboard.mozilla.org/r/207660/#review213650

::: browser/components/places/content/controller.js:733
(Diff revision 1)
>                                           defaultInsertionPoint: ip,
>                                           hiddenRows: [ "folderPicker" ]
>                                         }, window.top);
>      if (performed) {
>        // Select the new item.
> -      let insertedNodeId = PlacesUtils.bookmarks
> +      // XXX When we remove places transactions, we should be able to improve

Can we have a bug filed and a TODO (Bug 123): comment instead of XXX?
Attachment #8936938 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2254a714e53d
Allow Places tree's selectItems() function to handle guids as well as ids. r=mak
https://hg.mozilla.org/mozilla-central/rev/2254a714e53d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.