1425339 - Allow Places tree's selectItems() function to handle guids as well as ids.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P2)

Description

[Mark Banner (:standard8)]

In working on bug 1423896 we realised that we need to support a GUID passed to selectItems() on the places tree.

Doing this will allow us to switch the left folder pane queries to be based around (virtual) GUIDs which helps with the switch to virtual queries that we need to do.

This also helps with the general move away from ids to GUIDs.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids.

Review commit: https://reviewboard.mozilla.org/r/207660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207660/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8936938 [details]
Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids.

https://reviewboard.mozilla.org/r/207660/#review213650

::: browser/components/places/content/controller.js:733
(Diff revision 1)
>                                           defaultInsertionPoint: ip,
>                                           hiddenRows: [ "folderPicker" ]
>                                         }, window.top);
>      if (performed) {
>        // Select the new item.
> -      let insertedNodeId = PlacesUtils.bookmarks
> +      // XXX When we remove places transactions, we should be able to improve

Can we have a bug filed and a TODO (Bug 123): comment instead of XXX?

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8936938 [details]
Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207660/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2254a714e53d
Allow Places tree's selectItems() function to handle guids as well as ids. r=mak

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2254a714e53d