1425358 - Wait for all tab titles to be loaded in the Tabs.jsm screenshot configuration

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement)

Description

[Jared Wein [:jaws] (please needinfo? me)]

MattN pointed out to me that there were some screenshots that showed "about:addons" instead of "Add-ons Manager". We can wait until the tab title is displayed before taking the screenshot.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

Review commit: https://reviewboard.mozilla.org/r/207682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207682/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207682/diff/1-2/

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

https://reviewboard.mozilla.org/r/207682/#review213586

::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Tabs.jsm:141
(Diff revision 2)
> +  for (let tab of browserWindow.gBrowser.tabs) {
> +    let tabTitleLoaded = () => {
> +      let spec = tab.linkedBrowser &&
> +                 tab.linkedBrowser.documentURI &&
> +                 tab.linkedBrowser.documentURI.spec;
> +      return spec ? tab.label == specToTitleMap[spec] : true;

Shouldn't this be: `… : false`;? IIUC, it'll currently return true if the label doesn't matched the expected label.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207682/diff/2-3/

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

https://reviewboard.mozilla.org/r/207682/#review213678

Thanks

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd98493f58fa
Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for screenshot failures at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd98493f58fa4c5c9d55558c0d623fbc2ac9f3e6&filter-searchStr=screenshot&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=151839563

https://treeherder.mozilla.org/logviewer.html#?job_id=151853435&repo=autoland&lineNumber=5272

https://hg.mozilla.org/integration/autoland/rev/8643a82e172d08f86bf3a08e773c1743cc5a69d3

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207682/diff/3-4/

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207682/diff/4-5/

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=42906cfeb2838eac213e168270bf689471c117a7&selectedJob=151864127

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956979c14336
Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/956979c14336