Closed
Bug 1425358
Opened 2 years ago
Closed 2 years ago
Wait for all tab titles to be loaded in the Tabs.jsm screenshot configuration
Categories
(Testing :: mozscreenshots, enhancement)
Not set
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
Details
Attachments
(1 file)
MattN pointed out to me that there were some screenshots that showed "about:addons" instead of "Add-ons Manager". We can wait until the tab title is displayed before taking the screenshot.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936958 [details] Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. https://reviewboard.mozilla.org/r/207682/#review213586 ::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Tabs.jsm:141 (Diff revision 2) > + for (let tab of browserWindow.gBrowser.tabs) { > + let tabTitleLoaded = () => { > + let spec = tab.linkedBrowser && > + tab.linkedBrowser.documentURI && > + tab.linkedBrowser.documentURI.spec; > + return spec ? tab.label == specToTitleMap[spec] : true; Shouldn't this be: `… : false`;? IIUC, it'll currently return true if the label doesn't matched the expected label.
Attachment #8936958 -
Flags: review?(MattN+bmo)
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936958 [details] Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. https://reviewboard.mozilla.org/r/207682/#review213678 Thanks
Attachment #8936958 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/fd98493f58fa Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN
|
||
Comment 7•2 years ago
|
||
Backed out for screenshot failures at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd98493f58fa4c5c9d55558c0d623fbc2ac9f3e6&filter-searchStr=screenshot&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=151839563 https://treeherder.mozilla.org/logviewer.html#?job_id=151853435&repo=autoland&lineNumber=5272 https://hg.mozilla.org/integration/autoland/rev/8643a82e172d08f86bf3a08e773c1743cc5a69d3
Flags: needinfo?(jaws)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 10•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42906cfeb2838eac213e168270bf689471c117a7&selectedJob=151864127
Flags: needinfo?(jaws)
|
||
Comment 11•2 years ago
|
||
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/956979c14336 Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN
|
||
Comment 12•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/956979c14336
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•