Closed Bug 1425358 Opened 2 years ago Closed 2 years ago

Wait for all tab titles to be loaded in the Tabs.jsm screenshot configuration

Categories

(Testing :: mozscreenshots, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

MattN pointed out to me that there were some screenshots that showed "about:addons" instead of "Add-ons Manager". We can wait until the tab title is displayed before taking the screenshot.
Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

https://reviewboard.mozilla.org/r/207682/#review213586

::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/Tabs.jsm:141
(Diff revision 2)
> +  for (let tab of browserWindow.gBrowser.tabs) {
> +    let tabTitleLoaded = () => {
> +      let spec = tab.linkedBrowser &&
> +                 tab.linkedBrowser.documentURI &&
> +                 tab.linkedBrowser.documentURI.spec;
> +      return spec ? tab.label == specToTitleMap[spec] : true;

Shouldn't this be: `… : false`;? IIUC, it'll currently return true if the label doesn't matched the expected label.
Attachment #8936958 - Flags: review?(MattN+bmo)
Comment on attachment 8936958 [details]
Bug 1425358 - Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots.

https://reviewboard.mozilla.org/r/207682/#review213678

Thanks
Attachment #8936958 - Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/fd98493f58fa
Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/956979c14336
Wait for all tab titles to be displayed in Tabs.jsm before taking screenshots. r=MattN
https://hg.mozilla.org/mozilla-central/rev/956979c14336
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.