cppunit tests fail on Android 5+ because they are not PIE

RESOLVED FIXED in Firefox 59

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gbrown, Assigned: glandium)

Tracking

Trunk
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

As in bug 1338809, for xpcshell tests.
Priority: -- → P1
Attachment #8937977 - Flags: review?(mh+mozilla)
10 months have passed since bug 1338809 comment 6. Has the status of supporting Android < 4.1 changed? (as in, can we drop it?)
Flags: needinfo?(snorp)
The minimum SDK version is now 16 (Android 4.1) now, so yes, we can drop this.
Flags: needinfo?(snorp)
Comment on attachment 8937977 [details] [diff] [review]
build Android cppunit tests as PIE

Review of attachment 8937977 [details] [diff] [review]:
-----------------------------------------------------------------

So instead of this, let's enable PIE by default on android, and remove the -pie variant of the plugin-container (ipc/app/pie).
Attachment #8937977 - Flags: review?(mh+mozilla) → review-
One thing that's not clear to me is how we were launching the PIE plugin container after bug 1314466. The code that was choosing between the PIE and the non-PIE plugin-container binary was removed in that bug.
Flags: needinfo?(snorp)
Flags: needinfo?(rbarker)
Comment on attachment 8941683 [details]
Bug 1425381 - Always enable PIE on Android now that we support only >= 4.1.

https://reviewboard.mozilla.org/r/211928/#review217708

Yay!
Attachment #8941683 - Flags: review+
Thanks!
Assignee: gbrown → mh+mozilla
(In reply to Mike Hommey [:glandium] from comment #6)
> One thing that's not clear to me is how we were launching the PIE plugin
> container after bug 1314466. The code that was choosing between the PIE and
> the non-PIE plugin-container binary was removed in that bug.

We aren't ever launching the container process after that bug landed. Other standalone executables like the cppunit tests should be the only thing that cares about PIE.
Flags: needinfo?(snorp)
Attachment #8941683 - Flags: review?(core-build-config-reviews)
Flags: needinfo?(rbarker)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/10c18fb37dc9
Always enable PIE on Android now that we support only >= 4.1. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/10c18fb37dc9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.