Closed
Bug 1425381
Opened 6 years ago
Closed 6 years ago
cppunit tests fail on Android 5+ because they are not PIE
Categories
(Firefox for Android Graveyard :: Testing, defect, P1)
Firefox for Android Graveyard
Testing
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: gbrown, Assigned: glandium)
References
Details
Attachments
(2 files)
As in bug 1338809, for xpcshell tests.
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P1
|
|
Reporter | |
Comment 1•6 years ago
|
||
Attachment #8937977 -
Flags: review?(mh+mozilla)
|
Assignee | |
Comment 2•6 years ago
|
||
10 months have passed since bug 1338809 comment 6. Has the status of supporting Android < 4.1 changed? (as in, can we drop it?)
Flags: needinfo?(snorp)
The minimum SDK version is now 16 (Android 4.1) now, so yes, we can drop this.
Flags: needinfo?(snorp)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 8937977 [details] [diff] [review] build Android cppunit tests as PIE Review of attachment 8937977 [details] [diff] [review]: ----------------------------------------------------------------- So instead of this, let's enable PIE by default on android, and remove the -pie variant of the plugin-container (ipc/app/pie).
Attachment #8937977 -
Flags: review?(mh+mozilla) → review-
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•6 years ago
|
||
One thing that's not clear to me is how we were launching the PIE plugin container after bug 1314466. The code that was choosing between the PIE and the non-PIE plugin-container binary was removed in that bug.
Flags: needinfo?(snorp)
Flags: needinfo?(rbarker)
|
|
||
Comment 7•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8941683 [details] Bug 1425381 - Always enable PIE on Android now that we support only >= 4.1. https://reviewboard.mozilla.org/r/211928/#review217708 Yay!
Attachment #8941683 -
Flags: review+
(In reply to Mike Hommey [:glandium] from comment #6) > One thing that's not clear to me is how we were launching the PIE plugin > container after bug 1314466. The code that was choosing between the PIE and > the non-PIE plugin-container binary was removed in that bug. We aren't ever launching the container process after that bug landed. Other standalone executables like the cppunit tests should be the only thing that cares about PIE.
Flags: needinfo?(snorp)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8941683 -
Flags: review?(core-build-config-reviews)
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(rbarker)
|
||
Comment 10•6 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/10c18fb37dc9 Always enable PIE on Android now that we support only >= 4.1. r=froydnj
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/10c18fb37dc9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•