Closed Bug 1425390 Opened 2 years ago Closed 2 years ago

Make CompositionTransaction initializes itself with TextComposition

Categories

(Core :: DOM: Editor, defect)

56 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

(Keywords: inputmethod)

Attachments

(2 files)

I'd like to clean up around creating transactions.  However, CompositionTransaction blocks my idea because it takes a lot of local information at creating its instance.  It should be redesigned with TextComposition.
Comment on attachment 8937014 [details]
Bug 1425390 - part 1: Move some IME related members of EditorBase into TextComposition

https://reviewboard.mozilla.org/r/207744/#review213648
Attachment #8937014 - Flags: review?(m_kato) → review+
Comment on attachment 8937015 [details]
Bug 1425390 - part 2: Make the constructor of CompositionTransaction take TextComposition to reduce its arguments

https://reviewboard.mozilla.org/r/207746/#review213652
Attachment #8937015 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/d913369aa5ae
part 1: Move some IME related members of EditorBase into TextComposition r=m_kato
https://hg.mozilla.org/integration/autoland/rev/99f9646ec458
part 2: Make the constructor of CompositionTransaction take TextComposition to reduce its arguments r=m_kato
https://hg.mozilla.org/mozilla-central/rev/d913369aa5ae
https://hg.mozilla.org/mozilla-central/rev/99f9646ec458
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.