Closed Bug 1425455 Opened 7 years ago Closed 5 years ago

Black screen with "Checker Plus for Gmail" & "Amazon Assistant for Firefox" extension after landing patches from bug #1035091

Categories

(Core :: CSS Parsing and Computation, defect, P3)

59 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED WORKSFORME
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- wontfix
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix

People

(Reporter: Virtual, Unassigned)

References

Details

(Keywords: nightly-community, regression, reproducible, Whiteboard: [platform-rel-amazon] [platform-rel-Google] [platform-rel-Gmail])

STR: 1. Install "Checker Plus for Gmail™" extension ( https://addons.mozilla.org/en-US/firefox/addon/checker-plus-gmail/ ) 2. Open some GMail message 3. Scroll it and see black screen Other reports are in: bug #1422274 comment #2 bug #1422274 comment #12 bug #1422274 comment #14 Workaround: Set "layout.css.moz-document.content.enabled" preference to "true" in about:config Regression caused by: bug #1035091 Regression range pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ad2150e73c0b19f1f6264a4b9ad6927986d43ce&tochange=37e0bd919af057d44c5c1410458c0f00a3653c11
Has Regression Range: --- → yes
Has STR: --- → yes
Summary: Black screen with some extensions after landing patches from bug #1035091 → Black screen with "Checker Plus for Gmail" extension after landing patches from bug #1035091
Hi Jason, I see you're the developer of this extension: How are you using @-moz-document? Is there any kind of add-on API that would suit your add-on better?
Flags: needinfo?(apps)
As a workaround, I'm using this css directive to explicitly set the background to white in my extension. Note, I'm targeting Firefox only because this issue does not exist on Chrome. @-moz-document url-prefix() { #inbox, #openEmailScrollArea {background-color:white} body.background-skin #inbox, #openEmailScrollArea {background-color:rgba(255,255,255,0.1)} } I also mentioned it in this ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1417286#c9
Flags: needinfo?(apps)
per discussion, this seems to be the exactly same bug as bug 1417286, Feel free to combine them. Also it affects another addon "Amazon assistant" (check bug 1417286's comment), if we want to stick on this one, please CC their dev: bit-shared-platform@amazon.com
Summary: Black screen with "Checker Plus for Gmail" extension after landing patches from bug #1035091 → Black screen with "Checker Plus for Gmail" & "Amazon Assistant for Firefox" extension after landing patches from bug #1035091
Anything we should do here, other than waiting on extension changes?
Flags: needinfo?(emilio)
It's not 100% clear to me whether this is due to removing @-moz-document breaking a workaround for the black screen bug (potentially a graphics bug?), in which case we should figure out that one, or if it's a real CSS engine bug or something like that, in which case I could look into it. From the earlier comments I suspect it's the first, but confirmation would be nice.
Flags: needinfo?(emilio)
(In reply to Emilio Cobos Álvarez [:emilio] from comment #6) > It's not 100% clear to me whether this is due to removing @-moz-document > breaking a workaround for the black screen bug (potentially a graphics > bug?), in which case we should figure out that one, or if it's a real CSS > engine bug or something like that, in which case I could look into it. Who can do that?
Keywords: qawanted
(In reply to Emilio Cobos Álvarez [:emilio] from comment #6) > It's not 100% clear to me whether this is due to removing @-moz-document > breaking a workaround for the black screen bug I had somehow missed comment 0's thoroughness: (In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #0) > Set "layout.css.moz-document.content.enabled" preference to "true" in > about:config Does that answer your question, Emilio?
Flags: needinfo?(emilio)
Keywords: qawanted
(In reply to Andrew Overholt [:overholt] from comment #8) > > Set "layout.css.moz-document.content.enabled" preference to "true" in > > about:config > > Does that answer your question, Emilio? No, I know that enabling moz-document "fixes" the issue, but my reading of the other comments is that that @-moz-document rule is just working around the real issue, which looks like a gfx issue. Please correct me if I'm wrong.
Flags: needinfo?(emilio)
Ah, I see now that the root cause graphics bug is bug 1414033.
Depends on: 1414033
(In reply to Andrew Overholt [:overholt] from comment #10) > Ah, I see now that the root cause graphics bug is bug 1414033. I don't think that's true. What made you think so?
(In reply to Markus Stange [:mstange] from comment #11) > (In reply to Andrew Overholt [:overholt] from comment #10) > > Ah, I see now that the root cause graphics bug is bug 1414033. > > I don't think that's true. What made you think so? Hmm, I can't remember. But maybe because bug 1400259 comment 46 indicates the symptom here (the black background thing) is caused by "A container layer is holding on to its intermediate surface even though its child layers have changed." And the commit message there says "The bug has something to do with ContainerLayer nesting changes being mishandled: a new ContainerLayer for the transform is being inserted around the container layer for the opacity, which has an intermediate surface. This change makes the outer ContainerLayer permanent so that the dynamic insertion case is not hit." which I perhaps mis-intepreted as being bug 1414033. At any rate, is there anything we can do to avoid people working around the black background symptom with an @-moz-document?
Flags: needinfo?(mstange)
platform-rel: --- → ?
Whiteboard: [platform-rel-amazon] [platform-rel-Google] [platform-rel-Gmail]
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
fix-optional for 59 per P3 priority
This got triaged by the team back in January. Are there workarounds in these extensions at this point or is the problem still active?
Flags: needinfo?(Virtual)
Redirecting this question to extension developer.
Flags: needinfo?(Virtual) → needinfo?(apps)
Too late to fix in 63. We could still take a patch for 65 and potentially for 64.

Bulk change for all regression bugs with status-firefox67 as 'fix-optional' to be marked 'affected' for status-firefox68.

Bulk change to wontfix for 68 (P3+ carryover with needinfo).

Happy to take a patch for 70 but since this is triaged and set to P3 priority I'm setting it as fix-optional.
That will remove the bug from weekly regression triage.

Flags: needinfo?(apps)

I'm marking this bug as WORKSFORME, as I can't reproduce this issue anymore.

Status: NEW → RESOLVED
Closed: 5 years ago
platform-rel: ? → ---
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.