1425463 - Expose Console API to JSM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Andrea Marchesini [:baku]]

This is the first step to get rid of Console.jsm. Currently Console cannot be used by JSM code.
This is a good first step, but it's not enough to replace Console.jsm. What is still missing is:

1. a way to specify parameters such as prefix, max log level and so on.
2. introduce the stderr/stdout logging.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 0 - Console in JSM

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 1 - xpcshell test

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8937056 [details] [diff] [review]
part 0 - Console in JSM

>+Console::MonotonicTimer(JSContext* aCx, MethodName aMethodName,
>+                        const Sequence<JS::Value>& aData,
>+                        DOMHighResTimeStamp* aTimeStamp)
...
>+  if (NS_IsMainThread()) {
>+    *aTimeStamp = 0;
>+    return true;
>+  }
this doesn't look good to me. Makes timestamps rather useless on JSM, no?

Comment 4

[Andrea Marchesini [:baku]]

Attachment: console0.patch

Comment 5

[Andrea Marchesini [:baku]]

Attachment: console0.patch

This would basically work as the current Console.jsm. I don't have any better monotonic time to use.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8937665 [details] [diff] [review]
console0.patch

Timing attacks in .jsm? But ok, I guess we can keep this for consistency with Window case. But please make Performance::RoundTime a public static method and use that here. With that, r+. (we don't want to spread this magical 0.005 to several places)

(Note, worker part of the code doesn't have similar ReduceTimePrecisionAsMSecs usage. Should it? I think for consistency it should have. File a followup?)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df7c95d31077
Expose Console API to JSM, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f150d4c7c812
Expose Console API to JSM - xpcshell test, r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/df7c95d31077
https://hg.mozilla.org/mozilla-central/rev/f150d4c7c812