1425480 - Moving selection by word may break surrogate pairs

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement, P1)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase showing broken surrogate selection/editing with previous-word

User selection/editing actions should never break up surrogate pairs. Usually, we handle this OK (e.g. see fixes in bug 237585, bug 1068979), but the attachment shows a testcase where we still get it wrong.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Don't let nsTextFrame's ClusterIterator return an offset in the middle of a surrogate pair from GetAfterOffset()/GetBeforeOffset()

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Add word-movement testcases that include supplementary-plane (surrogate pair) characters

This includes a couple of examples that fail on current trunk, due to the bug here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e86819740d04
Don't let nsTextFrame's ClusterIterator return an offset in the middle of a surrogate pair from GetAfterOffset()/GetBeforeOffset(). r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/3126f89e3541
Add word-movement testcases that include supplementary-plane (surrogate pair) characters. r=m_kato

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e86819740d04
https://hg.mozilla.org/mozilla-central/rev/3126f89e3541