1425527 - form_cross_origin_insecure_action.html appears multiple times in a test manifest

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR: Run ./mach mochitest --total-chunks 5 --this-chunk 5

Expected: mochitests run

Actual:
Error running mach:

    ['mochitest', '--total-chunks', '5', '--this-chunk', '5']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: form_cross_origin_insecure_action.html appears multiple times in a test manifest under a support-files field, please omit the duplicate entry.

  File "/Users/kats/zspace/mozilla-w2/testing/mochitest/mach_commands.py", line 331, in run_mochitest_general
    driver.install_tests(tests)
  File "/Users/kats/zspace/mozilla-w2/python/mozbuild/mozbuild/controller/building.py", line 1273, in install_tests
    '_tests', test_objs)
  File "/Users/kats/zspace/mozilla-w2/python/mozbuild/mozbuild/testing.py", line 243, in install_test_files
    out_dir)
  File "/Users/kats/zspace/mozilla-w2/python/mozbuild/mozbuild/testing.py", line 131, in convert_support_files
    " please omit the duplicate entry." % (pattern, field))

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1425527 - Remove duplicate instances of a support file.

Review commit: https://reviewboard.mozilla.org/r/207828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207828/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8937123 [details]
Bug 1425527 - Remove duplicate instances of a support file.

https://reviewboard.mozilla.org/r/207828/#review213742

Thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ea232c87a7d
Remove duplicate instances of a support file. r=MattN

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9ea232c87a7d

Comment 5

[Kate McKinley [:kmckinley, :Kate]]

Comment on attachment 8937123 [details]
Bug 1425527 - Remove duplicate instances of a support file.

It looks like this has already landed.