Output frame tree when retained display list checker finds an issue

RESOLVED FIXED in Firefox 59

Status

()

Core
Layout: Web Painting
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: gerald, Assigned: gerald)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
Seeing the frame tree could help find causes of RDL issues.
Comment hidden (mozreview-request)

Comment 2

a month ago
mozreview-review
Comment on attachment 8937144 [details]
Bug 1425550 - Output frame tree when RDL checker finds issues -

https://reviewboard.mozilla.org/r/207858/#review213734

How frequent are failures now (with the subdoc patch). Can we add an NS_ASSERTION as well so that the failures create an orange?
Attachment #8937144 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 3

a month ago
(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8937144 [details]
> Bug 1425550 - Output frame tree when RDL checker finds issues -
> 
> https://reviewboard.mozilla.org/r/207858/#review213734

Thank you Matt for the review.

> How frequent are failures now (with the subdoc patch). Can we add an
> NS_ASSERTION as well so that the failures create an orange?

There are way fewer failures now, but last I looked there are still a few failures scattered around most test groups, such that it would probably make most tries look very orange! I will open a separate bug for that, and launch an experiment (after bug 1418840 lands) to gather some up-to-date data...

Comment 4

a month ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3eab9fd44dda
Output frame tree when RDL checker finds issues - r=mattwoodrow
Comment hidden (mozreview-request)
(Assignee)

Comment 7

a month ago
On it. Thank you Cosmin, and sorry for the trouble.
Flags: needinfo?(gsquelart)

Comment 8

a month ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dccea4ad69cb
Output frame tree when RDL checker finds issues - r=mattwoodrow

Comment 9

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dccea4ad69cb
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.