1425550 - Output frame tree when retained display list checker finds an issue

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Seeing the frame tree could help find causes of RDL issues.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1425550 - Output frame tree when RDL checker finds issues -

Review commit: https://reviewboard.mozilla.org/r/207858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207858/

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8937144 [details]
Bug 1425550 - Output frame tree when RDL checker finds issues -

https://reviewboard.mozilla.org/r/207858/#review213734

How frequent are failures now (with the subdoc patch). Can we add an NS_ASSERTION as well so that the failures create an orange?

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8937144 [details]
> Bug 1425550 - Output frame tree when RDL checker finds issues -
> 
> https://reviewboard.mozilla.org/r/207858/#review213734

Thank you Matt for the review.

> How frequent are failures now (with the subdoc patch). Can we add an
> NS_ASSERTION as well so that the failures create an orange?

There are way fewer failures now, but last I looked there are still a few failures scattered around most test groups, such that it would probably make most tries look very orange! I will open a separate bug for that, and launch an experiment (after bug 1418840 lands) to gather some up-to-date data...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eab9fd44dda
Output frame tree when RDL checker finds issues - r=mattwoodrow

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8937144 [details]
Bug 1425550 - Output frame tree when RDL checker finds issues -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207858/diff/1-2/

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on build/src/layout/base/nsLayoutUtils.cpp:3888:21

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3eab9fd44dda8e939027988572ef76270da35cce&filter-resultStatus=busted

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3eab9fd44dda8e939027988572ef76270da35cce&filter-resultStatus=busted

https://hg.mozilla.org/integration/autoland/rev/3b74c325e10f3ce6a6989ad1c0f9146133e29c50

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

On it. Thank you Cosmin, and sorry for the trouble.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dccea4ad69cb
Output frame tree when RDL checker finds issues - r=mattwoodrow

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dccea4ad69cb