1425555 - Avoid a fetch after showing the new bookmark dialog.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P1)

Description

[Mark Banner (:standard8)]

In controller.js -> newItem we are currently doing a fetch just after the call to PlacesUIUtils.showBookmarkDialog.

Once we remove the sync places transactions (bug 1131491), I think we should look at changing PlacesUIUtils.showBookmarkDialog so that it returns the new/affected guids.

newItem can then simply select the new guid.

This might not be possible due to how async PlacesTransactions work, but it feels like we should be able to somehow get the new guid to return somehow.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1425555 - Avoid a database fetch after showing the new bookmark dialog.

Review commit: https://reviewboard.mozilla.org/r/229576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/229576/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8960833 [details]
Bug 1425555 - Avoid a database fetch after showing the new bookmark dialog.

https://reviewboard.mozilla.org/r/229576/#review235402

it looks good and cheap :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed517bd510e7
Avoid a database fetch after showing the new bookmark dialog. r=mak

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ed517bd510e7