Closed Bug 1425566 Opened 2 years ago Closed 2 years ago

Take idle priority into account when collecting data for TIME_BETWEEN_UNLABELED_RUNNABLES_MS

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: farre, Assigned: farre)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → afarre
Attachment #8937159 - Flags: review?(erahm)
Attachment #8937159 - Attachment is obsolete: true
Attachment #8937159 - Flags: review?(erahm)
Attachment #8937161 - Flags: review?(erahm)
Comment on attachment 8937161 [details] [diff] [review]
0001-Bug-1425566-Collect-telemetry-for-unlabeled-idle-run.patch

Review of attachment 8937161 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, just one small nit.

::: xpcom/threads/nsThread.cpp
@@ +991,5 @@
>            timer.emplace(name);
>  
>            // High-priority runnables are ignored here since they'll run right away
>            // even with the cooperative scheduler.
> +          if (!labeled && priority > EventPriority::Input) {

Can you just make this explicit? The logic of `> EventPriority::Input` isn't obvious without looking up the enum.

ie:

> priority == EventPriority::Normal || EventPriority::Idle
Attachment #8937161 - Flags: review?(erahm) → review+
I'll make it so.
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d0fd4b639a
Collect telemetry for unlabeled idle runnables. r=erahm
https://hg.mozilla.org/mozilla-central/rev/26d0fd4b639a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.