Add the two names of the start/end markers in measure marker payload

RESOLVED FIXED in Firefox 60

Status

()

enhancement
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: brennan.brisad, Assigned: gregtatum)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

2 years ago
When creating a measure marker, it would be helpful if the Gecko profiler saved the names of the start and end markers (when available) into the payload for the measure marker.

The rationale being that perf.html could use those names to de-duplicate markers in its marker tables.  Please see the linked issue for more information.
Assignee

Updated

a year ago
Assignee: nobody → gtatum
Comment hidden (mozreview-request)
Comment on attachment 8957349 [details]
Bug 1425605 - Add the start/end mark names to performance.measure profiler markers;

https://reviewboard.mozilla.org/r/226274/#review232198

Looks good
Attachment #8957349 - Flags: review?(mstange) → review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8957349 [details]
Bug 1425605 - Add the start/end mark names to performance.measure profiler markers;

https://reviewboard.mozilla.org/r/226274/#review232254

::: tools/profiler/public/ProfilerMarkerPayload.h:14
(Diff revision 1)
>  
>  #include "mozilla/Attributes.h"
>  #include "mozilla/RefPtr.h"
>  #include "mozilla/TimeStamp.h"
>  #include "mozilla/UniquePtrExtensions.h"
> +#include "mozilla/Maybe.h"

alphabetic order here.
Attachment #8957349 - Flags: review?(amarchesini) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c26cb9769245
Add the start/end mark names to performance.measure profiler markers; r=baku,mstange

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c26cb9769245
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Posted file testcase-markers.html (obsolete) —
Here is a testcase to test the patch with.

Maybe it could be a good idea to run it while profiling in a mochitest ?
Posted file testcase-markers.html (obsolete) —
Adding some more problematic cases, when adding markers with the same names.
Attachment #8958419 - Attachment is obsolete: true
Attachment #8958455 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.