1425608 - Don't dispatch task in AutoTaskQueue to destroy its TaskQueue

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jean-Yves Avenard [:jya]]

TaskQueue no longer requires to be created or deleted on the main thread.

It is no longer necessary to dispatch a task on the main thread to shut it down.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1425608 - Don't delete AutoTaskQueue::mTaskQueue on the main thread.

Review commit: https://reviewboard.mozilla.org/r/207926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207926/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8937209 [details]
Bug 1425608 - Don't delete AutoTaskQueue::mTaskQueue on the main thread.

https://reviewboard.mozilla.org/r/207926/#review213778

::: commit-message-33588:1
(Diff revision 1)
> +Bug 1425608: Don't delete AutoTaskQueue::mTaskQueue on the main thread. r?gerald

Don't you mean "Only delete..."?

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8937209 [details]
Bug 1425608 - Don't delete AutoTaskQueue::mTaskQueue on the main thread.

https://reviewboard.mozilla.org/r/207926/#review213784

::: commit-message-33588:1
(Diff revision 1)
> +Bug 1425608: Don't delete AutoTaskQueue::mTaskQueue on the main thread. r?gerald

no no... don't delete the member on the main thread as what is happening now.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8937209 [details]
Bug 1425608 - Don't delete AutoTaskQueue::mTaskQueue on the main thread.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207926/diff/1-2/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8937209 [details]
Bug 1425608 - Don't delete AutoTaskQueue::mTaskQueue on the main thread.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/207926/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7b126878814
Don't delete AutoTaskQueue::mTaskQueue on the main thread. r=gerald

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c7b126878814