1425634 - Spidermonkey shell runs failing to generate stack traces

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Steve Fink [:sfink] [:s:]]

As glandium pointed out to me, the minidump_stackwalk binary I'm using is completely bogus.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Use a statically linked minidump_stackwalk for JS shell stacks (binary is from build-tools)

Now using the one from build-tools/breakpad/linux64/mindump_stackwalk

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Use a statically linked minidump_stackwalk for JS shell stacks (binary is from build-tools)

Oops, noticed that I hadn't changed the path where it is found.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8937230 [details] [diff] [review]
Use a statically linked minidump_stackwalk for JS shell stacks (binary is from build-tools)

Review of attachment 8937230 [details] [diff] [review]:
-----------------------------------------------------------------

I trust you did the right thing, but it would be better on the long term to make that breakpad-tools archive the result of a toolchain task.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8937230 [details] [diff] [review]
Use a statically linked minidump_stackwalk for JS shell stacks (binary is from build-tools)

Review of attachment 8937230 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/tooltool-manifests/linux64/jsshell.manifest
@@ +5,4 @@
>      "algorithm": "sha512",
>      "filename": "breakpad-tools.tar.xz",
>      "unpack": true
>    },

InvalidManifest: trying to read invalid manifest file

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cba1daf1c6f
Use a statically linked minidump_stackwalk for JS shell stacks (binary is from build-tools), r=glandium

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5cba1daf1c6f