1425701 - Assertion in AwaitAll causes tab crashes in debug builds

Status: RESOLVED INVALID

(Core :: WebRTC: Audio/Video, enhancement, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1425701: deleted unused TaskQueue RefPtr which hits assertions.

Review commit: https://reviewboard.mozilla.org/r/207996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207996/

Comment 2

[Jean-Yves Avenard [:jya]]

This code isn't in the tree. AwaitAll is added in bug 1404997 which hasn't been pushed yet.

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8937294 [details]
Bug 1425701: deleted unused TaskQueue RefPtr which hits assertions.

https://reviewboard.mozilla.org/r/207996/#review213838

Must have used aa working copy of bug

Comment 4

[Nils Ohlmeier [:drno]]

Sorry about that. I spend the flight home trying to figure out why I kept seeing theses crashes. And after having identified the problem I did not realize that padenot had based his patch on all old revision of bug 1404997.

Comment 5

[Jean-Yves Avenard [:jya]]

That caused a crash? A compilation warning sure... But that shouldn't crash. Ohhhhhh. Of course, shut-down wasn't called on it. I don't recall ever pushing that on reviewboard either. Maybe when I quickly fixed the crashes seen following Paul patches that caused a back out. 


I have the bug ready to land I believe.