1425702 - clear mIsTopLevelContentDocument / mIsContentDocument when a document is removed from a docshell

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Cameron McCormack (:heycam)]

Currently once these flags are set, they remain set forever.

Comment 1

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3dde1da29e8023d866446fc74d4c5e7ec80143a

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1425702 - Part 1: Add some docs for nsIDocument::{mIsTopLevelContentDocument,mIsContentDocument}.

Review commit: https://reviewboard.mozilla.org/r/208000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208000/

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1425702 - Part 2: Reset nsIDocument::{mIsTopLevelContentDocument,mIsContentDocument} when a document is removed from its docshell.

Review commit: https://reviewboard.mozilla.org/r/208002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208002/

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8937299 [details]
Bug 1425702 - Part 1: Add some docs for nsIDocument::{mIsTopLevelContentDocument,mIsContentDocument}.

https://reviewboard.mozilla.org/r/208000/#review214400

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8937300 [details]
Bug 1425702 - Part 2: Reset nsIDocument::{mIsTopLevelContentDocument,mIsContentDocument} when a document is removed from its docshell.

https://reviewboard.mozilla.org/r/208002/#review214402

This doesn't look right to me.  In particular, ReportUseCounters() uses these members and is called in nsDocument::~nsDocument, which presumably comes after we SetContainer(nullptr).