1425750 - Developer Toolbox shows "The address isn't valid" with downloaded builds

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Richard Marti (:Paenglab)]

The Developer Toolbox shows "The address isn't valid" with downloaded builds. No error in the console. With self built TB and run from obj-dir it still works.

Last good tinderbox build: 20171123090219
https://hg.mozilla.org/comm-central/rev/27ab0eeb6c58b7a5e015f39f54cf96aeeb94c486
https://hg.mozilla.org/mozilla-central/rev/b6bed1b710c3e22cab49f22f1b5f44d80286bcb9

First bad tinderbox build: 20171123145319
https://hg.mozilla.org/comm-central/rev/154e8b31b4856c3a961ad881056e1d842078e744
https://hg.mozilla.org/mozilla-central/rev/3f5d48c08903475b5f556f3d5906773978b30489

Comment 1

[Richard Marti (:Paenglab)]

Philipp, as the "TB devtools specialist" do you know what could be the problem?

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/pushloghtml?fromchange=27ab0eeb6c58b7a5e015f39f54cf96aeeb94c486&tochange=154e8b31b4856c3a961ad881056e1d842078e744

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b6bed1b710c3e22cab49f22f1b5f44d80286bcb9&tochange=3f5d48c08903475b5f556f3d5906773978b30489

Most likely this bit we didn't port:
http://hg.mozilla.org/mozilla-central/rev/f320e72a945f5f2c39c6a8fbddb30f3ada3834fe

Richard, would you mind adding
+@RESPATH@/browser/components/aboutdevtoolstoolbox-registration.js
+@RESPATH@/browser/components/aboutdevtoolstoolbox.manifest
and then push this to try to see whether that works.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug1425750.patch

Try build: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7ee4b06ad200c34e2ba9380bf7ed11a6af92c191

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8937365 [details] [diff] [review]
Bug1425750.patch

Yep, this was it.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8937365 [details] [diff] [review]
Bug1425750.patch

There were a few changes to port I e-mailed you about, this was one of them. It got forgotten :-(

I'll land this soon after the next merge, I have two other patches.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b045d93bbd53
Port bug 1386979 to TB/IB/SM: add aboutdevtoolstoolbox to package manifests. r=jorgk