1425809 - recording-list-item-save button overlaps with vertical scrollbar

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[magicp]

Attachment: recording-list-item-save.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171217220404

Steps to reproduce:
1. Launch Nightly on Windows
2. Open Performance Tools (Shift+F5)
3. Record performance several times until displaying vertical scrollbar in recording list

Actual results:
Save button overlap with vertical scrollbar.

Expected results:
Save button don't overlap with vertical scrollbar like a snapshot list in Memory Tool.

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=66a77b9bfe5dcacd50eccf85de7c0e7e15ce0ffd&tochange=f7d5008ee2ab9200052e45ad6ecc3f3a348f7f86

Comment 1

[Julien Wajsberg [:julienw]]

I reproduce.

I think this is fixed by removing the lines in [1]:

  width: var(--sidebar-width);
  min-width: var(--sidebar-width);

[1] https://searchfox.org/mozilla-central/rev/51cd1093c5c2113e7b041e8cc5c9bf2186abda13/devtools/client/themes/performance.css#165-166

Greg, do you see any reason why these lines should be kept?

Comment 2

[Greg Tatum [:gregtatum]]

I know that the mixed HTML and XUL breaks very easily here, and there isn't any dynamic sizing.

Comment 4

[Anca Soncutean, Desktop QA]

Note that similar behavior occurs also, in Style Editor pane. The overlapping issue is triggered instead, when resizing the pane - see screenshot: https://drive.google.com/open?id=1yGAcE2SF8Aw96Yd1ZS4PdzEblkSaJ50m . 
Moreover, in dark theme, the scrollbar overlapping the text is barely visible and the current selected sheet indicator (the triangle sign) shows a different response from the light theme - see screenshot: https://drive.google.com/open?id=1BuX19AZYv252dCz9b2sxJZmh95eaeCnJ .

Comment 5

[Anca Soncutean, Desktop QA]

In addition, I have to mention that I reproduced the overlapping issue (when the light theme is set) on the latest Nightly 62.0a1 (2018-06-18), only in about:newtab page. 

Sorry about the flags! I mentioned them in the comment above by mistake. Therefore I will update the status flags of this bug, for the current release cycle.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I believe that this is related to the old Performance panel implementation (which has been removed) and not relevant anymore.
Closing, but correct me if I am wrong.