142582 - Mac: Some plugins crash when window->window is NULL during NPP_SetWindow

Status: VERIFIED DUPLICATE of bug 120875

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Frankie]

Consider this to be a Talkback submission (see bug 116795).

Using 2002050608 latest-trunk for OS X, I went to My Yahoo page, opened a news
article (some dutch guy was shot) in a tab, then clicked Yahoo mail. Mozilla
crashed, log follows.

Comment 1

[Frankie]

Attachment: console crash log May 6

Comment 2

[Matthias Versen [:Matti]]

-> Plugins

Comment 3

[Peter Lubczynski]

-->this is my bug

Reporter: What plugin were you using that cause the crash? If you are not sure,
can you copy/paste what you see in about:plugins here. Thanks!

Comment 4

[Frankie]

I can't say for sure, but since it was on Yahoo, most likely a Flash advert.

My full list is:
MRJPlugin Carbon 1.0fc2
Shockwave Flash NP-PPC 5.0r58
PluginLib (aka Shockwave) 8.5.1r102
iTools Plug-in 2.07
QuickTime plugin.plugin 5.02

Comment 5

[rubydoo123]

putting into 1.0.1 : crash

Comment 6

[Frankie]

Attachment: crash log May 7 and 8

Two more crashes on various Yahoo pages.

This bug definitely started in the past week. It must be due to something that
was added recently.

Comment 7

[Frankie]

Updated to 2002050803 latest-trunk. Had another crash, pretty much identical to
the previous 3.

Mozilla no longer working in the #1 web site seems like a problem. I'm going to
update to Flash 6, see if it affects anything.

Comment 8

[Frankie]

Okay, it's definitely Flash. When I went to Macromedia's Flash 6 download page, 
Mozilla crashed. Log follows.

Comment 9

[Frankie]

Attachment: crash log at Macromedia

Comment 10

[Peter Lubczynski]

*** Bug 143050 has been marked as a duplicate of this bug. ***

Comment 11

[m_mozilla]

Peter, bug 143050 does not involve Flash.

Are you sure it's a dup?

I believe bug 143050 is quicktime:

<EMBED
    SRC="../videos/navigator.mov"
    PLUGINSPAGE="http://quicktime.apple.com"
    WIDTH=256 HEIGHT=208
    CONTROLLER=true LOOP=true AUTOPLAY=true
>

Should this bug be expanded to cover quicktime as well, or should bug 143050 be
un-dupped?

-matt

Comment 12

[Peter Lubczynski]

Yes, this is all the same bug. It appears that there are exceptions to what's in
the plugin API doc:
http://developer.netscape.com/docs/manuals/communicator/plugin/draw.htm#1005612

> Communicator can also call NPP_SetWindow multiple times with different values for
> the window, including null. For example, if a user removes an instance from the 
> page, Communicator should call NPP_SetWindow with a window value of null. This 
> value prevents the instance from drawing further until it is pasted back on the
> page and NPP_SetWindow is called again with a new value. 

I'm looking at it now.

Comment 13

[Peter Lubczynski]

Alrighty, here's what I've found:

The 4.x plugin documentation is wrong. NPWindow.window can not be NULL. However,
if CGrafPtr in NP_Port is NULL, it appears to do the right thing. So I'll try to
wip up a patch where NPWindow.window.port = NULL and do more testing.

Comment 14

[Peter Lubczynski]

*** Bug 142851 has been marked as a duplicate of this bug. ***

Comment 15

[Peter Lubczynski]

*** Bug 143286 has been marked as a duplicate of this bug. ***

Comment 16

[Peter Lubczynski]

Attachment: patch v.1

This patch clears the clip and port if the plugin should not be visible and
removes the extra call to SetWindow().

Comment 17

[anthonyd]

reviewed and tested on carbon build on mac os x.

r=anthonyd

Comment 18

[Matthias Versen [:Matti]]

*** Bug 143223 has been marked as a duplicate of this bug. ***

Comment 19

[Peter Lubczynski]

*** Bug 144162 has been marked as a duplicate of this bug. ***

Comment 20

[Peter Lubczynski]

*** Bug 139544 has been marked as a duplicate of this bug. ***

Comment 21

[Duncan Wilcox]

Coming from bug 144162 (flash content crashes plugin on MacOS X), I'm using
nightly build 2002051314 on MacOS X and I still see the crash. The crash doesn't
always happen however. I load http://radio.weblogs.com/0106797/ and sometimes it
crashes right away. If it doesn't I hit command-T (to open a new tab) and this
always crashes (different crash):

 #0   0x041b98c0 in PlayerWnd::SetWindow(_NPWindow *)
 #1   0x041b9888 in PlayerWnd::SetWindow(_NPWindow *)
 #2   0x041b77fc in NPP_SetWindow
 #3   0x041fba3c in Private_SetWindow(_NPP *, _NPWindow *)
 #4   0x02b128d0 in ns4xPluginInstance::SetWindow(nsPluginWindow *)
 #5   0x030c6768 in nsPluginInstanceOwner::FixUpPluginWindow(void)
 #6   0x030c5688 in nsPluginInstanceOwner::Notify(nsITimer *)
 #7   0x00626080 in nsTimerImpl::Fire(void)
 #8   0x006261fc in handleTimerEvent(TimerEventType *)
 #9   0x005f13b0 in PL_HandleEvent
 #10  0x005f121c in PL_ProcessPendingEvents
 ...more backtrace...

My flash plugin is:
Shockwave Flash 5.0 r58

Comment 22

[Matthias Versen [:Matti]]

*** Bug 144170 has been marked as a duplicate of this bug. ***

Comment 23

[Andy Rudmik]

I reinstalled the Flash player and things are not crashing anymore.

Comment 24

[rubydoo123]

adding graffiti

Comment 25

[Peter Lubczynski]

*** Bug 144767 has been marked as a duplicate of this bug. ***

Comment 26

[Frankie]

Attachment: Crash log at apple/quicktime

Concurring with Adam's comment, I haven't had a Flash crash since the 8th, when
I updated my plugin. I wonder how reinstalling changes the picture?

Occasional crashes in QuickTime though. This one happened while I was headed to
Apple hoping to reinstall QT and see if that does the trick.

Comment 27

[Peter Lubczynski]

will be fixed with bug 120875

*** This bug has been marked as a duplicate of 120875 ***

Comment 28

[rubydoo123]

removing PL RTM cruft since this is a dup of bug 120875

Comment 29

[shrirang khanzode]

mass duplicate verifications . For filtering purposes, pls use keywd
"massdupverification"