1425834 - Parse ::slotted when the webcomponents pref is on.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

This depends on all the other fixes for slotted hanging from bug 1424604.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Cascade order is still not the spec'd, but I intend to fix that in a followup too.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

Review commit: https://reviewboard.mozilla.org/r/208120/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208120/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8937455 [details]
Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/208120/diff/1-2/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8937455 [details]
Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

https://reviewboard.mozilla.org/r/208120/#review214372

::: servo/components/style/gecko/selector_parser.rs:336
(Diff revision 2)
>  
>  impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
>      type Impl = SelectorImpl;
>      type Error = StyleParseErrorKind<'i>;
>  
> +    fn parse_slotted(&self) -> bool {

I wonder whether it's worth adding `#[inline]` here...

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8937455 [details]
Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

https://reviewboard.mozilla.org/r/208120/#review216540

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc488833671
Update test expectations for partial ::slotted support. r=heycam

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1bc488833671