Parse ::slotted when the webcomponents pref is on.

RESOLVED FIXED in Firefox 59

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

This depends on all the other fixes for slotted hanging from bug 1424604.
Cascade order is still not the spec'd, but I intend to fix that in a followup too.
Comment on attachment 8937455 [details]
Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

https://reviewboard.mozilla.org/r/208120/#review214372

::: servo/components/style/gecko/selector_parser.rs:336
(Diff revision 2)
>  
>  impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
>      type Impl = SelectorImpl;
>      type Error = StyleParseErrorKind<'i>;
>  
> +    fn parse_slotted(&self) -> bool {

I wonder whether it's worth adding `#[inline]` here...
Attachment #8937455 - Flags: review+
Priority: -- → P1
Comment on attachment 8937455 [details]
Bug 1425834: style: Parse ::slotted() if the webcomponents pref is on.

https://reviewboard.mozilla.org/r/208120/#review216540
Attachment #8937455 - Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1bc488833671
Update test expectations for partial ::slotted support. r=heycam
https://hg.mozilla.org/mozilla-central/rev/1bc488833671
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.