JS modules tests related to referrer policy fail

RESOLVED FIXED in Firefox 59

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago
The following web platform test currently fail:

html/semantics/scripting-1/the-script-element/module/referrer-no-referrer.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-origin-when-cross-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-same-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-unsafe-url.sub.html
(Assignee)

Comment 1

a month ago
Created attachment 8937476 [details] [diff] [review]
bug1425843-module-referrer

It turns out we don't pass the correct referrer or referrer policy for modules.

Patch to make it do that, storing both in the ScriptLoadRequest.  The referrer for an imported module is set to the URI of its parent request in the ModuleLoadRequest constructor.
Attachment #8937476 - Flags: review?(bugs)

Updated

a month ago
Attachment #8937476 - Flags: review?(bugs) → review+

Comment 2

a month ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6d8af1cda7
Pass correct referrer and referrer policy when fetching modules r=smaug
Priority: -- → P2

Comment 3

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd6d8af1cda7
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.