Closed Bug 1425843 Opened 6 years ago Closed 6 years ago

JS modules tests related to referrer policy fail

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

bug1425843-module-referrer
19.13 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
The following web platform test currently fail:

html/semantics/scripting-1/the-script-element/module/referrer-no-referrer.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-origin-when-cross-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-same-origin.sub.html
html/semantics/scripting-1/the-script-element/module/referrer-unsafe-url.sub.html
It turns out we don't pass the correct referrer or referrer policy for modules.

Patch to make it do that, storing both in the ScriptLoadRequest.  The referrer for an imported module is set to the URI of its parent request in the ModuleLoadRequest constructor.
Attachment #8937476 - Flags: review?(bugs)
Attachment #8937476 - Flags: review?(bugs) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6d8af1cda7
Pass correct referrer and referrer policy when fetching modules r=smaug
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/fd6d8af1cda7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: