Closed Bug 1425868 Opened 2 years ago Closed 2 years ago

Consolidate arrow panel styling

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(2 files)

Split out the following items from bug 1408121:

- Convert arrow panels to use CSS vars
  -> Also got a green light from :shorlander at the y'all hands to remove the linear gradient on macOS

- Convert identity panel images to use context-fill
Assignee: nobody → ntim.bugs
Comment on attachment 8937490 [details]
Bug 1425868 - Consolidate arrow panel styling.

https://reviewboard.mozilla.org/r/208164/#review214110

::: toolkit/themes/windows/global/popup.css:109
(Diff revision 2)
>  }
>  
>  %ifdef XP_WIN
>  @media (-moz-windows-default-theme) {
>    .panel-arrowcontent {
>      --arrowpanel-border-color: hsla(210,4%,10%,.2);

This won't affect the arrow's border since the arrow isn't inside panel-arrowcontent. This should probably move to global.css.
Attachment #8937490 - Flags: review?(dao+bmo)
Comment on attachment 8937490 [details]
Bug 1425868 - Consolidate arrow panel styling.

https://reviewboard.mozilla.org/r/208164/#review214138

Looks good, thanks!
Attachment #8937490 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4f6ed26bdb9b
Consolidate arrow panel styling. r=dao
Blocks: 1411606
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/778dfad0f75e
Consolidate arrow panel styling. r=dao
Depends on: 1426128
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/1ef8164691910d9eb3ee0812c2881352c46e08f5
chore(styles): Port Bug 1425868 - Activity Stream changes to info panel (#3907)
https://hg.mozilla.org/mozilla-central/rev/778dfad0f75e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.