Closed Bug 1425967 Opened 2 years ago Closed 2 years ago

browser_UsageTelemetry.js is going to permafail when the Gecko version number is bumped to 60

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: Gijs)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Looks like the test depends on the TAB_COUNT histogram which is set to expire in 60. What do you want to do with this, Gijs?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> [Tracking Requested - why for this release]: Permafailing tests when the
> Gecko version number is bumped to 60.
> 
> Looks like the test depends on the TAB_COUNT histogram which is set to
> expire in 60. What do you want to do with this, Gijs?

I don't know. The original request for telemetry was done by bsmedberg, who's not at Mozilla anymore. I imagine Mossop has a useful opinion on whether we need to keep that telemetry, or if he doesn't, he might know who does. :-)
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(dtownsend)
I don't have a useful opinion. UX might...
Flags: needinfo?(dtownsend) → needinfo?(shorlander)
(In reply to Dave Townsend [:mossop] from comment #2)
> I don't have a useful opinion. UX might...

I don't think we should let this expire.
Flags: needinfo?(shorlander)
The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January. 

Who can follow up and work on fixing this (which I guess means extending the expire date)?
Dão, asking you as triage owner for the component.
Flags: needinfo?(dao+bmo)
I can take the code change.

(In reply to Stephen Horlander [:shorlander] from comment #3)
> (In reply to Dave Townsend [:mossop] from comment #2)
> > I don't have a useful opinion. UX might...
> 
> I don't think we should let this expire.

FWIW, I think data/privacy review folks will want to have a little bit more information about why this is important / what it gets us. Even something like "we use this for every shield study to check retention / usage" or "this helps us evaluate whether people use few/many tabs and how to prioritize the UI design for those cases" or whatever. But "something" more than just "we shouldn't let this expire. Especially if I'm flipping this to 'never'. :-)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo) → needinfo?(shorlander)
(In reply to :Gijs from comment #5)
> I can take the code change.
> 
> (In reply to Stephen Horlander [:shorlander] from comment #3)
> > (In reply to Dave Townsend [:mossop] from comment #2)
> > > I don't have a useful opinion. UX might...
> > 
> > I don't think we should let this expire.
> 
> FWIW, I think data/privacy review folks will want to have a little bit more
> information about why this is important / what it gets us. Even something
> like "we use this for every shield study to check retention / usage" or
> "this helps us evaluate whether people use few/many tabs and how to
> prioritize the UI design for those cases" or whatever. But "something" more
> than just "we shouldn't let this expire. Especially if I'm flipping this to
> 'never'. :-)

This "this helps us evaluate whether people use few/many tabs and how to prioritize the UI design for those cases" is right :)

Specifically in this case we have tentative plans for tab improvements in 2018 and having this data is likely going to be important.

On a more general note about all of these UI probes that track usage of things: they help us to make decisions on how to make Firefox better and what work to prioritize. The "issue" is that we don't always know when we are going to need the data. So if they expire then we can't retroactively get the information we need when we need it.
Flags: needinfo?(shorlander)
Comment on attachment 8939584 [details]
Bug 1425967 - extend TAB_COUNT probe to last until 65,

https://reviewboard.mozilla.org/r/209904/#review215492

Thanks!
Attachment #8939584 - Flags: review?(mconley) → review+
Comment on attachment 8939584 [details]
Bug 1425967 - extend TAB_COUNT probe to last until 65,

Try confirms that this fixes the issues with this test.
Attachment #8939584 - Flags: feedback+
Comment on attachment 8939584 [details]
Bug 1425967 - extend TAB_COUNT probe to last until 65,

https://reviewboard.mozilla.org/r/209904/#review216908

Approving extending of this probe to 65.
Attachment #8939584 - Flags: review?(liuche) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7e989a375aa8
extend TAB_COUNT probe to last until 65, r=liuche,mconley
https://hg.mozilla.org/mozilla-central/rev/7e989a375aa8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.