Closed Bug 142597 Opened 18 years ago Closed 18 years ago

Dictionary names in spelling dialog are not localized (regression)

Categories

(Core :: Localization, defect, P3)

x86
All
defect

Tracking

()

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: mwawoczny, Assigned: cmanske)

References

Details

(Keywords: intl, regression, Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm-)

Attachments

(2 files, 1 obsolete file)

Dictionary names in spelling dialog are not localized (regression), attaching screenshot and patch.

Mozilla/5.0 (Windows; U; Windows NT 5.0; pl-PL; rv:1.0.0+) Gecko/20020504
Component: Editor: Core → Localization
Keywords: patch, regression
Attached patch Patch (uses <stringbundle> tag) (obsolete) — Splinter Review
Confirm the bug, cc to tao.
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 143057 has been marked as a duplicate of this bug. ***
Can I get someone familiar in the ways of UI localization and stringbundles to
review this? cmanske? brade? yokoyama? I can sr afterwards.
Assignee: kin → cmanske
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Check this bug: http://bugzilla.mozilla.org/show_bug.cgi?id=56680 - "use a xul <stringbundle/> instead of including the strres.js code"
Building NS tree now and will test/review asap.
Status: NEW → ASSIGNED
Keywords: nsbeta1+
Whiteboard: [RTM]
Attached patch patch v2Splinter Review
Updated patch; seems to need "getString" when using XUL stringbundle element.
Attachment #82509 - Attachment is obsolete: true
Whiteboard: [RTM] → [RTM][FIX IN HAND][need r=,sr=]
Blocks: 141008
Keywords: intl
Comment on attachment 83087 [details] [diff] [review]
patch v2

r=andreww not  sure about the getString issue. You might want to get someone
like Hewitt or Blake for super review and to reality-check that. I see both
instances in the existing code	- like in:
http://lxr.mozilla.org/seamonkey/source/extensions/wallet/editor/WalletEditor.j
s#684
Attachment #83087 - Flags: review+
Whiteboard: [RTM][FIX IN HAND][need r=,sr=] → [RTM][FIX IN HAND][need sr=]
Comment on attachment 83087 [details] [diff] [review]
patch v2

sr=hewitt
Attachment #83087 - Flags: superreview+
Whiteboard: [RTM][FIX IN HAND][need sr=] → [RTM][FIX IN HAND]
cmanske- could you land into trunk asap and mark bug as fixed.
IQA- please verify trunk after cmanske land into trunk. Thanks
checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [RTM][FIX IN HAND] → [adt3 RTM][FIXED_IN_TRUNK]
can someone in IQA please verify this ? thanks
cc: yuying also...ylong, can you make sure someone in IQA verifies this one?
thanks...
I saw this get fixed on 05-17 trunk build/WinME-JA - they are showing language
names instead of language ID now.

Mark as verified.
Status: RESOLVED → VERIFIED
Whiteboard: [adt3 RTM][FIXED_IN_TRUNK] → [adt3 RTM][VERIFIED_IN_TRUNK]
Keywords: adt1.0.0
Keywords: approval
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers approval.  After, checking in, please add the fixed1.0 keyword.
Keywords: adt1.0.0adt1.0.0+
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK] → [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=]
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.
Keywords: adt1.0.0+adt1.0.1+
Keywords: mozilla1.0.1
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=] → [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=],custrtm
Target Milestone: mozilla1.0 → mozilla1.0.1
a=chofmann for 1.0.1
Comment on attachment 83087 [details] [diff] [review]
patch v2

Marking chofmann's a=
Attachment #83087 - Flags: approval+
please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK] [Needs a=],custrtm → [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm
oops! forgot to mention I just checked in fix to 1.0.1 branch
ylong, please verify on branch and add "verified1.0.1" keyword. thanks
Whiteboard: [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm → [adt3 RTM][VERIFIED_IN_TRUNK][FIXED_IN_BRANCH],custrtm-
Blocks: 146292
No longer blocks: 141008
Verified on 06-05 branch build on WinXP-SC.
You need to log in before you can comment on or make changes to this bug.