Closed Bug 1425970 Opened 3 years ago Closed 3 years ago

browser_abandonment_telemetry.js is going to permafail when the Gecko version number is bumped to 60

Categories

(Core :: General, enhancement)

enhancement
Not set
major

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: mconley)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Looks like the test depends on the BUSY_TAB_ABANDONED probe, which is set to expire in Gecko 60. How should we proceed here, Mike?
Flags: needinfo?(mconley)
The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January.
digitarald is on the hook for BUSY_TAB_ABANDONED, I think, based on https://searchfox.org/mozilla-central/rev/51cd1093c5c2113e7b041e8cc5c9bf2186abda13/toolkit/components/telemetry/Histograms.json#13176-13184. If he still thinks the probe is useful, we can extend it, and we're fine. If the probe is not useful, we should just remove the test.
Flags: needinfo?(mconley) → needinfo?(hkirschner)
The probe helped to inform anomalies in a pref flipping experiment (users abandoned a lot more pages by refreshing in one branch( that had no other indicator. I'd like to keep this for now until we a better metric for success/failure of page loads.
Flags: needinfo?(hkirschner)
Hey liuche, here's another probe we'd like to extend. Okay to sign-off with data-review+?
Flags: needinfo?(liuche)
Assignee: nobody → mconley
Comment on attachment 8939871 [details]
Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. , data-review=liuche

https://reviewboard.mozilla.org/r/210186/#review215882
Attachment #8939871 - Flags: review?(jaws) → review+
Comment on attachment 8939871 [details]
Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. , data-review=liuche

Try confirms that this fixes the issues with this test.
Attachment #8939871 - Flags: review?(liuche)
Attachment #8939871 - Flags: feedback+
Comment on attachment 8939871 [details]
Bug 1425970 - Extend BUSY_TAB_ABANDONED probe lifetime until v65. , data-review=liuche

https://reviewboard.mozilla.org/r/210186/#review216864

Yes! Approving this extension of the probe.
Attachment #8939871 - Flags: review?(liuche) → review+
Flags: needinfo?(liuche)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b16d13518be9
Extend BUSY_TAB_ABANDONED probe lifetime until v65. r=jaws,liuche, data-review=liuche
https://hg.mozilla.org/mozilla-central/rev/b16d13518be9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Status: RESOLVED → VERIFIED
Blocks: 1488948
You need to log in before you can comment on or make changes to this bug.