browser_checkAddonCompatibility.js is going to permafail when the Gecko version number is bumped to 60

VERIFIED FIXED in Firefox 59

Status

()

Firefox
Search
P1
major
VERIFIED FIXED
29 days ago
9 days ago

People

(Reporter: RyanVM, Assigned: standard8)

Tracking

Trunk
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59- verified)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (obsolete)
(Reporter)

Comment 1

29 days ago
[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Bah, hit submit too soon there. Disregard comment 0. Looks like the followonsearch install.rdf has a maxVersion of 59.* at the moment, causing the test to fail when the Gecko version number is 60.
status-firefox57: --- → unaffected
status-firefox58: --- → unaffected
status-firefox-esr52: --- → unaffected
tracking-firefox59: --- → ?
Flags: needinfo?(standard8)
Summary: browser_abandonment_telemetry.js is going to permafail when the Gecko version number is bumped to 60 → browser_checkAddonCompatibility.js is going to permafail when the Gecko version number is bumped to 60
(Assignee)

Updated

29 days ago
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Priority: -- → P1
Whiteboard: [fxsearch]
(Assignee)

Comment 2

29 days ago
I think we should just bump the version number here. When we can get to the add-on being a full WebExtension, then the max version will likely go away.

I don't really want to go the pre-processing route, as that complicates the github repo.

So for now, we'll just add approx another year of compatibility onto it.
Comment hidden (mozreview-request)

Comment 4

28 days ago
mozreview-review
Comment on attachment 8937700 [details]
Bug 1425977 - Bump the maximum version number for the follow-on search add-on.

https://reviewboard.mozilla.org/r/208416/#review214336

Sounds good to me!
Attachment #8937700 - Flags: review?(past) → review+

Comment 5

28 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0d32976847e1
Bump the maximum version number for the follow-on search add-on. r=past

Comment 6

28 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d32976847e1
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
(Reporter)

Updated

13 days ago
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
tracking-firefox59: ? → -
You need to log in before you can comment on or make changes to this bug.