Closed Bug 1425977 Opened 2 years ago Closed 2 years ago

browser_checkAddonCompatibility.js is going to permafail when the Gecko version number is bumped to 60

Categories

(Firefox :: Search, enhancement, P1, major)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 - verified

People

(Reporter: RyanVM, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing tests when the Gecko version number is bumped to 60.

Bah, hit submit too soon there. Disregard comment 0. Looks like the followonsearch install.rdf has a maxVersion of 59.* at the moment, causing the test to fail when the Gecko version number is 60.
Flags: needinfo?(standard8)
Summary: browser_abandonment_telemetry.js is going to permafail when the Gecko version number is bumped to 60 → browser_checkAddonCompatibility.js is going to permafail when the Gecko version number is bumped to 60
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Priority: -- → P1
Whiteboard: [fxsearch]
I think we should just bump the version number here. When we can get to the add-on being a full WebExtension, then the max version will likely go away.

I don't really want to go the pre-processing route, as that complicates the github repo.

So for now, we'll just add approx another year of compatibility onto it.
Comment on attachment 8937700 [details]
Bug 1425977 - Bump the maximum version number for the follow-on search add-on.

https://reviewboard.mozilla.org/r/208416/#review214336

Sounds good to me!
Attachment #8937700 - Flags: review?(past) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0d32976847e1
Bump the maximum version number for the follow-on search add-on. r=past
https://hg.mozilla.org/mozilla-central/rev/0d32976847e1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.