Closed Bug 1425979 Opened 6 years ago Closed 6 years ago

test_migration2to3.js is going to permafail when Gecko 59 merges to Beta on 2018-01-11

Categories

(Core :: Security, defect)

Product:
Core
Component:
Security
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

migration.patch
2.25 KB, patch
jkt
: review+
RyanVM
: feedback+
Details | Diff | Splinter Review 
[Tracking Requested - why for this release]: Permafailing test when Gecko 59 merges to Beta on January 11.

https://treeherder.mozilla.org/logviewer.html#?job_id=150917203&repo=try

TEST-UNEXPECTED-FAIL | toolkit/components/contextualidentity/tests/unit/test_migration2to3.js | cookieDeleted - [cookieDeleted : 104] We should not have the new cookie! - false == true
Flags: needinfo?(amarchesini)
The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January.
tracking-firefox59: ? → +
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attached patch migration.patch (obsolete) — — Splinter Review 

        Attachment #8938381 -
        Flags: review?(jkt)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        migration.patch
        — 
          — Splinter Review
      

    


  

        Attachment #8938381 -
        Attachment is obsolete: true

        Attachment #8938381 -
        Flags: review?(jkt)

        Attachment #8938383 -
        Flags: review?(jkt)

    
    

    
  
Comment on attachment 8938383 [details] [diff] [review]
migration.patch

Try likes this, thanks!

        Attachment #8938383 -
        Flags: feedback+

        Attachment #8938383 -
        Flags: review?(jkt) → review+

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/816fbb9103df
test_migration2to3 should be executed only if in nightly, r=jkt

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/816fbb9103df
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox59:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

    
  
Status: RESOLVED → VERIFIED

          status-firefox59:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.