1425986 - --disable-ion should disable wasm signal handler

Status: RESOLVED DUPLICATE of bug 1627255

(Core :: JavaScript Engine, defect, P2)

Description

[Mike Hommey [:glandium]]

When building with --disable-ion, the wasm signal handler is still setup, which is useless. In fact, it seems wasm should not be built at all.

Comment 1

[Jason Orendorff [:jorendorff]]

Luke, what do you think?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Mike Hommey [:glandium] from comment #0)
> In fact, it seems wasm should not be built at all.

We used to not build most of js/src/jit/ with --disable-ion but now we just use a dummy backend (js/src/jit/none/), to avoid having to sprinkle lots of #ifdefs everywhere.

Comment 3

[Lars T Hansen [:lth]]

Hm, --disable-ion....  Wasm has a baseline compiler now, which does not use Ion.  But I guess --disable-ion reallly means 'disable all machine code generation'?

Comment 4

[Mike Hommey [:glandium]]

Yes, it's a bad name for --disable-jit.

Comment 5

[Luke Wagner [:luke]]

AFAIK, --disable-ion isn't a shipping configuration for which we care about performance, so the only criteria here is what makes the code simpler.  If slicing things differently simplifies things, patches welcome.