Closed Bug 1425992 Opened 2 years ago Closed 2 years ago

browser_startup_flicker.js is going to permafail when Gecko 59 merges to Beta on 2018-01-11

Categories

(Firefox :: General, defect, critical)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 + verified

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=150916313&repo=try

TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_flicker.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_flicker.js:12 - TypeError: Cc['@mozilla.org/test/startuprecorder;1'] is undefined
Flags: needinfo?(florian)
The early/first merge will be Jan. 11th. 
Tracking so we can make sure to check back in early January.
This got IRC r+ from Florian already. Since startuprecorder.js is only shipped on debug and trunk builds, only attempt to run the test there. Green on Try.
Assignee: nobody → ryanvm
Flags: needinfo?(florian)
Attachment #8938178 - Flags: review+
Comment on attachment 8938178 [details] [diff] [review]
only run the test on debug and trunk builds

Review of attachment 8938178 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/performance/browser.ini
@@ +17,5 @@
>  [browser_startup.js]
>  [browser_startup_content.js]
>  skip-if = !e10s
>  [browser_startup_flicker.js]
> +run-if = debug || nightly_build # Requires startuprecorder.js, which is only available on debug & trunk

nit: startupRecorder.js, not startuprecorder.js
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ca8505867b1a
Only run browser_startup_flicker.js on debug and trunk builds. r=florian
https://hg.mozilla.org/mozilla-central/rev/ca8505867b1a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.