Closed Bug 1426006 Opened 4 years ago Closed 4 years ago

(--disable-ion) testPreserveJitCode.cpp:78:CHECK_EQUAL failed: expected (1u) = 1, got (countIonScripts(global)) = 0 | testPreserveJitCode.cpp:22:CHECK failed: testPreserveJitCode(false, 0)

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: glandium, Assigned: sfink)

References

Details

Attachments

(1 file)

Bug 1426003 adds build jobs with --disable-ion. The tests are disabled in those jobs because there are various failures.

This bug is about the following jsapi-tests failure:
[task 2017-12-18T23:48:47.853Z] test_PreserveJitCode
[task 2017-12-18T23:48:47.853Z] TEST-UNEXPECTED-FAIL | test_PreserveJitCode | /builds/worker/workspace/build/src/js/src/jsapi-tests/testPreserveJitCode.cpp:78:CHECK_EQUAL failed: expected (1u) = 1, got (countIonScripts(global)) = 0 | /builds/worker/workspace/build/src/js/src/jsapi-tests/testPreserveJitCode.cpp:22:CHECK failed: testPreserveJitCode(false, 0)
Steve, could you patch this?
Flags: needinfo?(sphink)
Priority: -- → P1
You win the random review request recipient contest!
Attachment #8953344 - Flags: review?(bbouvier)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Comment on attachment 8953344 [details] [diff] [review]
Do not expect ion scripts when ion is unavailable

Review of attachment 8953344 [details] [diff] [review]:
-----------------------------------------------------------------

And you win a non-random r+! Thanks.
Attachment #8953344 - Flags: review?(bbouvier) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a9f2cf4ca3f
Do not expect ion scripts when ion is unavailable, r=bbouvier
https://hg.mozilla.org/mozilla-central/rev/7a9f2cf4ca3f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Want to request uplift for 59 beta? This could still make Thursday's beta 14 build.
Comment on attachment 8953344 [details] [diff] [review]
Do not expect ion scripts when ion is unavailable

Approval Request Comment
[Feature/Bug causing the regression]: bitrot of untested configuration
[User impact if declined]: none
[Is this code covered by automated tests?]: yes, bug 1426003, but it's disabled while it's broken
[Has the fix been verified in Nightly?]: not used in Nightly, so no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: bug 1426008, which I haven't gotten to yet
[Is the change risky?]: no
[Why is the change risky/not risky?]: not part of any shipping build
[String changes made/needed]: none

To be clear, I would like to uplift this both for tier 3 platforms that use Spidermonkey without the JIT, and for differential testing. Uplifting this bug won't fix the problem, but it's safe to uplift this independently.
Flags: needinfo?(sphink)
Attachment #8953344 - Flags: approval-mozilla-beta?
Comment on attachment 8953344 [details] [diff] [review]
Do not expect ion scripts when ion is unavailable

Let's uplift for beta 14.
Attachment #8953344 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I didn't notice that this needs bug 1426008.  Looks like we shouldn't uplift this until we have a fix there too.
Attachment #8953344 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-
From irc conversation with sfink, we can hold off on this till 60.
Comment on attachment 8953344 [details] [diff] [review]
Do not expect ion scripts when ion is unavailable

...except when I looked into bug 1426008, it turns out that it was already fixed in 59. So I'd like to re-request approval-mozilla-beta.
If this and bug 1426008 are fixed, can't we enable the tests on these builds now?
Comment on attachment 8953344 [details] [diff] [review]
Do not expect ion scripts when ion is unavailable

Great. let's uplift this fix to m-r for next week's RC build.
Attachment #8953344 - Flags: approval-mozilla-beta- → approval-mozilla-release+
(In reply to Mike Hommey [:glandium] from comment #12)
> If this and bug 1426008 are fixed, can't we enable the tests on these builds
> now?

As long as something else hasn't broken as well, yes.
Blocks: 1442508
Duplicate of this bug: 1208526
You need to log in before you can comment on or make changes to this bug.