Closed Bug 1426018 Opened 3 years ago Closed 3 years ago

Netmonitor requests-list-headers has incorrect position in the Firebug theme

Categories

(DevTools :: Netmonitor, defect, P4)

defect

Tracking

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: magicp.jp, Assigned: tera_1225)

References

Details

Attachments

(2 files)

Steps to reproduce:
1. Launch Nightly
2. Open Netmonitor in the Firebug theme

Actual results:
Netmonitor requests-list-headers has incorrect position in the Firebug theme.

Expected results:
requests-list-headers fits in requests-list-headers-wrapper.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=10777aa50c49e929145fcd84a10892c0db099862&tochange=083a5838f76a418779c2f4fc01152bc3be355fc0
Blocks: 1360457
Has Regression Range: --- → yes
Has STR: --- → yes
Will have a look at this too, as it's my own regression. Can somebody assign me please?
Flags: needinfo?(odvarko)
Thanks for the report, I can reproduce the bug on my machine.

Honza
Flags: needinfo?(odvarko)
Priority: -- → P4
Assignee: nobody → tera_1225
Status: NEW → ASSIGNED
(In reply to tera_1225 from comment #1)
> Will have a look at this too, as it's my own regression. Can somebody assign
> me please?
Done, thanks for helping with the issue.

Honza
Comment on attachment 8937860 [details]
Bug 1426018 Added padding to request-list-header-wrapper firebug theme.

https://reviewboard.mozilla.org/r/208546/#review214408

Looks good to me, thanks!

Honza
Attachment #8937860 - Flags: review?(odvarko) → review+
No problem, my pleasure :)
(In reply to tera_1225 from comment #6)
> No problem, my pleasure :)

To make sure the patch is landed you need to add 'checkin-needed' into Keywords field (under Tracking section) - after R+. This way bugzilla Sheriffs know that it's ready to land.
(I am doing it now)

Thanks,
Honza
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ab16e9b4bcd
Added padding to request-list-header-wrapper firebug theme. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8ab16e9b4bcd
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
This bug fix has verified in the latest Nightly build (20171221220104). Thanks tera_1225!
This only happened with Firebug theme and it's a UI enhancement. Let's let it ride the train and won't fix for 58.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.