1426031 - Ensure gfxVRGVR SubmitFrame is called on the correct thread

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Randall Barker [:rbarker]]

The addition of the VRThread broke gfxVRGVR. All GoogleVR rendering calls must be made on the same thread that the library was initialized on. VRDisplayHost::SubmitFrameInternal() needs to be invoked on the Compositor Thread for the GVR implementation.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1426031 - Ensure gfxVRGVR SubmitFrame is called on the correct thread

Review commit: https://reviewboard.mozilla.org/r/208290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208290/

Comment 2

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8937619 [details]
Bug 1426031 - Ensure gfxVRGVR SubmitFrame is called on the correct thread

https://reviewboard.mozilla.org/r/208290/#review214060

lgtm. thank!

Comment 3

[Daosheng Mu[:daoshengmu]]

We are going to separate our VR module into a separate process in January. I encourage you to enable our vr reftest on Android to avoid this kind of regression in the future.

Comment 4

[Randall Barker [:rbarker]]

(In reply to Daosheng Mu[:daoshengmu] from comment #3)
> We are going to separate our VR module into a separate process in January. I
> encourage you to enable our vr reftest on Android to avoid this kind of
> regression in the future.

I've already spoken to :kip about this, Android can not have its GVR implementation moved into a separate process. The GVR API must always be invoked within the same thread (the controller API is the sole exception) and those threads must be in the same process as the UI Thread. Of course SVR and Oculus Mobile will add additional wrinkles as they are added.

Currently we can not build GeckoView with GVR enabled on test machines and even if we could, would require a pixel to run. The reftests using the PuppetVR class would not have caught this. In the future it would probably be beneficial to include me when making architectural changes so I can provide feedback on how it will affect mobile.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9d182f7c389
Ensure gfxVRGVR SubmitFrame is called on the correct thread r=daoshengmu

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/e9d182f7c389